summaryrefslogtreecommitdiff
path: root/src/soc/amd/picasso/acpi
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2020-08-03 23:16:43 +0200
committerFelix Held <felix-coreboot@felixheld.de>2020-08-04 21:37:44 +0000
commit9e757a0ab0f9dd7bec29133419fa68c9201f9a4e (patch)
tree45b74889496eeb3874b5777a90c0250075d26b99 /src/soc/amd/picasso/acpi
parent8f917b1d4bb9a51fa08933c7c458fbfe5b896bb6 (diff)
soc/amd/picasso/acpi: clean up global NVS
Some fields in GNVS seem to be copied over from Apollolake to Stoneyridge to Picasso. This patch removes the unused fields. BUG=b:161165393 TEST=Mandolin still boots and dmesg shows no new ACPI errors. Change-Id: I8c6b580543089bf0180a7caeb9e6a47dc4ed4a1d Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/44154 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Raul Rangel <rrangel@chromium.org>
Diffstat (limited to 'src/soc/amd/picasso/acpi')
-rw-r--r--src/soc/amd/picasso/acpi/globalnvs.asl28
1 files changed, 9 insertions, 19 deletions
diff --git a/src/soc/amd/picasso/acpi/globalnvs.asl b/src/soc/amd/picasso/acpi/globalnvs.asl
index 8147619ab5..6e63b8da5e 100644
--- a/src/soc/amd/picasso/acpi/globalnvs.asl
+++ b/src/soc/amd/picasso/acpi/globalnvs.asl
@@ -17,25 +17,15 @@ Field (GNVS, ByteAcc, NoLock, Preserve)
/* Miscellaneous */
Offset (0x00),
PCNT, 8, // 0x00 - Processor Count
- PPCM, 8, // 0x01 - Max PPC State
- LIDS, 8, // 0x02 - LID State
- PWRS, 8, // 0x03 - AC Power State
- DPTE, 8, // 0x04 - Enable DPTF
- CBMC, 32, // 0x05 - 0x08 - coreboot Memory Console
- PM1I, 64, // 0x09 - 0x10 - System Wake Source - PM1 Index
- GPEI, 64, // 0x11 - 0x18 - GPE Wake Source
- NHLA, 64, // 0x19 - 0x20 - NHLT Address
- NHLL, 32, // 0x21 - 0x24 - NHLT Length
- PRT0, 32, // 0x25 - 0x28 - PERST_0 Address
- SCDP, 8, // 0x29 - SD_CD GPIO portid
- SCDO, 8, // 0x2A - GPIO pad offset relative to the community
- TMPS, 8, // 0x2B - Temperature Sensor ID
- TLVL, 8, // 0x2C - Throttle Level Limit
- FLVL, 8, // 0x2D - Current FAN Level
- TCRT, 8, // 0x2E - Critical Threshold
- TPSV, 8, // 0x2F - Passive Threshold
- TMAX, 8, // 0x30 - CPU Tj_max
- Offset (0x34), // 0x34 - AOAC Device Enables
+ LIDS, 8, // 0x01 - LID State
+ PWRS, 8, // 0x02 - AC Power State
+ CBMC, 32, // 0x03 - 0x06 - coreboot Memory Console
+ PM1I, 64, // 0x07 - 0x0e - System Wake Source - PM1 Index
+ GPEI, 64, // 0x0f - 0x16 - GPE Wake Source
+ TMPS, 8, // 0x17 - Temperature Sensor ID
+ TCRT, 8, // 0x18 - Critical Threshold
+ TPSV, 8, // 0x19 - Passive Threshold
+ Offset (0x20), // 0x20 - AOAC Device Enables
, 7,
IC2E, 1, // I2C2, 7
IC3E, 1, // I2C3, 8