summaryrefslogtreecommitdiff
path: root/src/soc/amd/phoenix
diff options
context:
space:
mode:
authorFred Reitberger <reitbergerfred@gmail.com>2023-07-05 15:43:19 -0400
committerFred Reitberger <reitbergerfred@gmail.com>2023-07-07 12:50:15 +0000
commite66ce2f4181b14ffe323e559805b2a5f97b0c1bd (patch)
treea56205a35072a6e1f151571ba8c72e4f727f419d /src/soc/amd/phoenix
parent8b42a05fed9764a718babbc2d77c0dd0437ebb6c (diff)
soc/amd/*/Makefile.inc: Use _tohex instead of printf
Use the _tohex function to convert values to hex instead of 'shell printf' TEST=timeless builds identical for grunt,dalboz,guybrush,chausie,birman Signed-off-by: Fred Reitberger <reitbergerfred@gmail.com> Change-Id: Ic7f7d1b764479088cc0980b208d8d603bc712832 Reviewed-on: https://review.coreboot.org/c/coreboot/+/76314 Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com> Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Diffstat (limited to 'src/soc/amd/phoenix')
-rw-r--r--src/soc/amd/phoenix/Makefile.inc10
1 files changed, 5 insertions, 5 deletions
diff --git a/src/soc/amd/phoenix/Makefile.inc b/src/soc/amd/phoenix/Makefile.inc
index c65c36979a..b15b5d6a47 100644
--- a/src/soc/amd/phoenix/Makefile.inc
+++ b/src/soc/amd/phoenix/Makefile.inc
@@ -134,14 +134,14 @@ PSP_BIOSBIN_DEST=$(shell $(READELF_bootblock) -Wl $(PSP_ELF_FILE) | grep LOAD |
# type = 0x63 - construct APOB NV base/size from flash map
# The flashmap section used for this is expected to be named RW_MRC_CACHE
APOB_NV_SIZE=$(call get_fmap_value,FMAP_SECTION_RW_MRC_CACHE_SIZE)
-APOB_NV_BASE=$(shell printf "%#x" $(call int-subtract, \
+APOB_NV_BASE=$(call _tohex,$(call int-subtract, \
$(call get_fmap_value,FMAP_SECTION_RW_MRC_CACHE_START) $(FMAP_FLASH_START)))
ifeq ($(CONFIG_HAS_RECOVERY_MRC_CACHE),y)
# On boards with recovery MRC cache, point type 0x63 entry to RECOVERY_MRC_CACHE.
# Else use RW_MRC_CACHE. This entry will be added in the RO section.
APOB_NV_RO_SIZE=$(call get_fmap_value,FMAP_SECTION_RECOVERY_MRC_CACHE_SIZE)
-APOB_NV_RO_BASE=$(shell printf "%#x" $(call int-subtract, \
+APOB_NV_RO_BASE=$(call _tohex,$(call int-subtract, \
$(call get_fmap_value,FMAP_SECTION_RECOVERY_MRC_CACHE_START) $(FMAP_FLASH_START)))
else
APOB_NV_RO_SIZE=$(APOB_NV_SIZE)
@@ -263,7 +263,7 @@ $(obj)/amdfw.rom: $(call strip_quotes, $(PSP_BIOSBIN_FILE)) \
$(OPT_VERSTAGE_FILE) \
$(OPT_VERSTAGE_SIG_FILE) \
$(OPT_SPL_TABLE_FILE) \
- --location $(shell printf "%#x" $(PHOENIX_FWM_POSITION)) \
+ --location $(call _tohex,$(PHOENIX_FWM_POSITION)) \
--output $@
ifeq ($(CONFIG_AMDFW_SPLIT),y)
@@ -288,7 +288,7 @@ $(obj)/amdfw_a.rom: $(obj)/amdfw.rom
$(OPT_SPL_RW_AB_TABLE_FILE) \
$(OPT_SIGNED_AMDFW_A_POSITION) \
$(OPT_SIGNED_AMDFW_A_FILE) \
- --location $(shell printf "%#x" $(PHOENIX_FW_A_POSITION)) \
+ --location $(call _tohex,$(PHOENIX_FW_A_POSITION)) \
--anywhere \
--output $@
@@ -302,7 +302,7 @@ $(obj)/amdfw_b.rom: $(obj)/amdfw.rom
$(OPT_SPL_RW_AB_TABLE_FILE) \
$(OPT_SIGNED_AMDFW_B_POSITION) \
$(OPT_SIGNED_AMDFW_B_FILE) \
- --location $(shell printf "%#x" $(PHOENIX_FW_B_POSITION)) \
+ --location $(call _tohex,$(PHOENIX_FW_B_POSITION)) \
--anywhere \
--output $@