soc/amd/*/data_fabric: Use common device ops

Use the common device ops instead of an soc-specific device ops.

TEST=builds for each soc

Signed-off-by: Fred Reitberger <reitbergerfred@gmail.com>
Change-Id: I1804200c3c3f5ab492d237f4b03484c383862caf
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69174
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>

4 files changed, 16 insertions, 52 deletions

diff --git a/src/soc/amd/mendocino/Makefile.inc b/src/soc/amd/mendocino/Makefile.inc
index 44a0e29149..e1dda83870 100644
--- a/src/soc/amd/mendocino/Makefile.inc
+++ b/src/soc/amd/mendocino/Makefile.inc
@@ -34,7 +34,6 @@ ramstage-y	+= acpi.c
 ramstage-y	+= agesa_acpi.c
 ramstage-y	+= chip.c
 ramstage-y	+= cpu.c
-ramstage-y	+= data_fabric.c
 ramstage-y	+= fch.c
 ramstage-y	+= fsp_s_params.c
 ramstage-y	+= gpio.c
diff --git a/src/soc/amd/mendocino/chipset_mendocino.cb b/src/soc/amd/mendocino/chipset_mendocino.cb
index 23afdba8a3..29002799da 100644
--- a/src/soc/amd/mendocino/chipset_mendocino.cb
+++ b/src/soc/amd/mendocino/chipset_mendocino.cb
@@ -74,14 +74,14 @@ chip soc/amd/mendocino
 		device pci 14.0 alias smbus on ops amd_smbus_ops end # primary FCH function
 		device pci 14.3 alias lpc_bridge on ops amd_lpc_ops end
 
-		device pci 18.0 alias data_fabric_0 on ops mendocino_data_fabric_ops end
-		device pci 18.1 alias data_fabric_1 on ops mendocino_data_fabric_ops end
-		device pci 18.2 alias data_fabric_2 on ops mendocino_data_fabric_ops end
-		device pci 18.3 alias data_fabric_3 on ops mendocino_data_fabric_ops end
-		device pci 18.4 alias data_fabric_4 on ops mendocino_data_fabric_ops end
-		device pci 18.5 alias data_fabric_5 on ops mendocino_data_fabric_ops end
-		device pci 18.6 alias data_fabric_6 on ops mendocino_data_fabric_ops end
-		device pci 18.7 alias data_fabric_7 on ops mendocino_data_fabric_ops end
+		device pci 18.0 alias data_fabric_0 on ops amd_data_fabric_ops end
+		device pci 18.1 alias data_fabric_1 on ops amd_data_fabric_ops end
+		device pci 18.2 alias data_fabric_2 on ops amd_data_fabric_ops end
+		device pci 18.3 alias data_fabric_3 on ops amd_data_fabric_ops end
+		device pci 18.4 alias data_fabric_4 on ops amd_data_fabric_ops end
+		device pci 18.5 alias data_fabric_5 on ops amd_data_fabric_ops end
+		device pci 18.6 alias data_fabric_6 on ops amd_data_fabric_ops end
+		device pci 18.7 alias data_fabric_7 on ops amd_data_fabric_ops end
 	end
 
 	device mmio 0xfedc2000 alias i2c_0 off ops soc_amd_i2c_mmio_ops end
diff --git a/src/soc/amd/mendocino/chipset_rembrandt.cb b/src/soc/amd/mendocino/chipset_rembrandt.cb
index 23afdba8a3..29002799da 100644
--- a/src/soc/amd/mendocino/chipset_rembrandt.cb
+++ b/src/soc/amd/mendocino/chipset_rembrandt.cb
@@ -74,14 +74,14 @@ chip soc/amd/mendocino
 		device pci 14.0 alias smbus on ops amd_smbus_ops end # primary FCH function
 		device pci 14.3 alias lpc_bridge on ops amd_lpc_ops end
 
-		device pci 18.0 alias data_fabric_0 on ops mendocino_data_fabric_ops end
-		device pci 18.1 alias data_fabric_1 on ops mendocino_data_fabric_ops end
-		device pci 18.2 alias data_fabric_2 on ops mendocino_data_fabric_ops end
-		device pci 18.3 alias data_fabric_3 on ops mendocino_data_fabric_ops end
-		device pci 18.4 alias data_fabric_4 on ops mendocino_data_fabric_ops end
-		device pci 18.5 alias data_fabric_5 on ops mendocino_data_fabric_ops end
-		device pci 18.6 alias data_fabric_6 on ops mendocino_data_fabric_ops end
-		device pci 18.7 alias data_fabric_7 on ops mendocino_data_fabric_ops end
+		device pci 18.0 alias data_fabric_0 on ops amd_data_fabric_ops end
+		device pci 18.1 alias data_fabric_1 on ops amd_data_fabric_ops end
+		device pci 18.2 alias data_fabric_2 on ops amd_data_fabric_ops end
+		device pci 18.3 alias data_fabric_3 on ops amd_data_fabric_ops end
+		device pci 18.4 alias data_fabric_4 on ops amd_data_fabric_ops end
+		device pci 18.5 alias data_fabric_5 on ops amd_data_fabric_ops end
+		device pci 18.6 alias data_fabric_6 on ops amd_data_fabric_ops end
+		device pci 18.7 alias data_fabric_7 on ops amd_data_fabric_ops end
 	end
 
 	device mmio 0xfedc2000 alias i2c_0 off ops soc_amd_i2c_mmio_ops end
diff --git a/src/soc/amd/mendocino/data_fabric.c b/src/soc/amd/mendocino/data_fabric.c
deleted file mode 100644
index e0942f2ab8..0000000000
--- a/src/soc/amd/mendocino/data_fabric.c
+++ /dev/null
@@ -1,35 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <acpi/acpi_device.h>
-#include <console/console.h>
-#include <device/device.h>
-#include <device/pci.h>
-#include <soc/pci_devs.h>
-
-static const char *data_fabric_acpi_name(const struct device *dev)
-{
-	const char *df_acpi_names[8] = {
-		"DFD0",
-		"DFD1",
-		"DFD2",
-		"DFD3",
-		"DFD4",
-		"DFD5",
-		"DFD6",
-		"DFD7"
-	};
-
-	if (dev->path.type == DEVICE_PATH_PCI &&
-	    PCI_SLOT(dev->path.pci.devfn) == DF_DEV)
-		return df_acpi_names[PCI_FUNC(dev->path.pci.devfn)];
-
-	printk(BIOS_ERR, "%s: Unhandled device id 0x%x\n", __func__, dev->device);
-	return NULL;
-}
-
-struct device_operations mendocino_data_fabric_ops = {
-	.read_resources		= noop_read_resources,
-	.set_resources		= noop_set_resources,
-	.acpi_name		= data_fabric_acpi_name,
-	.acpi_fill_ssdt		= acpi_device_write_pci_dev,
-};