summaryrefslogtreecommitdiff
path: root/src/soc/amd/glinda
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2023-01-20 23:39:17 +0100
committerFelix Held <felix-coreboot@felixheld.de>2023-02-06 12:14:24 +0000
commitba74a036d07d557c941a3f69f6e354c9da874a30 (patch)
tree3f39ee96aeb348d5b09517c422095096f8b8bf02 /src/soc/amd/glinda
parente8dfb330eb63c4ed3a383577ddd18a2f751c2437 (diff)
soc/amd/glinda: remove LIDS field from global NVS
Since the LIDS field is only used in the ACPI code and not in the C code of any mainboard using the Glinda SoC, remove it form the global NVS. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: I627d05c09d9637caf15e17285dd2c8e0389747c5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/72187 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Raul Rangel <rrangel@chromium.org>
Diffstat (limited to 'src/soc/amd/glinda')
-rw-r--r--src/soc/amd/glinda/acpi/globalnvs.asl7
-rw-r--r--src/soc/amd/glinda/include/soc/nvs.h7
2 files changed, 6 insertions, 8 deletions
diff --git a/src/soc/amd/glinda/acpi/globalnvs.asl b/src/soc/amd/glinda/acpi/globalnvs.asl
index cc0453aa35..512f9e8a9f 100644
--- a/src/soc/amd/glinda/acpi/globalnvs.asl
+++ b/src/soc/amd/glinda/acpi/globalnvs.asl
@@ -8,8 +8,7 @@
Field (GNVS, ByteAcc, NoLock, Preserve)
{
/* Miscellaneous */
- LIDS, 8, // 0x00 - LID State
- CBMC, 32, // 0x01 - 0x04 - coreboot Memory Console
- PM1I, 64, // 0x05 - 0x0c - System Wake Source - PM1 Index
- GPEI, 64, // 0x0d - 0x14 - GPE Wake Source
+ CBMC, 32, // 0x00 - 0x03 - coreboot Memory Console
+ PM1I, 64, // 0x04 - 0x0b - System Wake Source - PM1 Index
+ GPEI, 64, // 0x0c - 0x13 - GPE Wake Source
}
diff --git a/src/soc/amd/glinda/include/soc/nvs.h b/src/soc/amd/glinda/include/soc/nvs.h
index d328e68132..1e663e4ca3 100644
--- a/src/soc/amd/glinda/include/soc/nvs.h
+++ b/src/soc/amd/glinda/include/soc/nvs.h
@@ -13,10 +13,9 @@
struct __packed global_nvs {
/* Miscellaneous */
- uint8_t lids; /* 0x00 - LID State */
- uint32_t cbmc; /* 0x01 - 0x04 - coreboot Memory Console */
- uint64_t pm1i; /* 0x05 - 0x0c - System Wake Source - PM1 Index */
- uint64_t gpei; /* 0x0d - 0x14 - GPE Wake Source */
+ uint32_t cbmc; /* 0x00 - 0x03 - coreboot Memory Console */
+ uint64_t pm1i; /* 0x04 - 0x0b - System Wake Source - PM1 Index */
+ uint64_t gpei; /* 0x0c - 0x13 - GPE Wake Source */
};
#endif /* AMD_GLINDA_NVS_H */