summaryrefslogtreecommitdiff
path: root/src/soc/amd/genoa
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2023-12-05 00:41:05 +0100
committerFelix Held <felix-coreboot@felixheld.de>2023-12-06 16:01:18 +0000
commitf5b09dbe1840e2ba2bbc9b2c6225e838cb7a32b9 (patch)
tree3f3224e9ceb971d762207c1c733e37b4d930e10c /src/soc/amd/genoa
parent3e306d48cd9f862e55e4458da0eb2c6a606cb796 (diff)
soc/amd/*/chipset.cb: don't call dummy device functions host bridges
Function 0 of the devices that have the bridges to other buses are dummy functions that can be left enabled to not have to shuffle around the device function numbers when the first PCI bridge on those devices isn't enabled. Those dummy device functions are however not PCI host bridges, so change the comments from 'Dummy Host Bridge' to 'Dummy device function'. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Suggested-by: Nico Huber <nico.h@gmx.de> Change-Id: Ibddfdf558d84bc44434d718b86f41bd06044b22a Reviewed-on: https://review.coreboot.org/c/coreboot/+/79396 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Diffstat (limited to 'src/soc/amd/genoa')
-rw-r--r--src/soc/amd/genoa/chipset.cb48
1 files changed, 24 insertions, 24 deletions
diff --git a/src/soc/amd/genoa/chipset.cb b/src/soc/amd/genoa/chipset.cb
index 0f543e74c1..1e90eb58fc 100644
--- a/src/soc/amd/genoa/chipset.cb
+++ b/src/soc/amd/genoa/chipset.cb
@@ -9,7 +9,7 @@ chip soc/amd/genoa
device pci 00.2 alias iommu_0 on ops amd_iommu_ops end
device pci 00.3 alias rcec_0 off end
- device pci 01.0 on end # Dummy Host Bridge, do not disable
+ device pci 01.0 on end # Dummy device function, do not disable
device pci 01.1 alias gpp_bridge_0_0_a off end
device pci 01.2 alias gpp_bridge_0_1_a off end
device pci 01.3 alias gpp_bridge_0_2_a off end
@@ -18,11 +18,11 @@ chip soc/amd/genoa
device pci 01.6 alias gpp_bridge_0_5_a off end
device pci 01.7 alias gpp_bridge_0_6_a off end
- device pci 02.0 on end # Dummy Host Bridge, do not disable
+ device pci 02.0 on end # Dummy device function, do not disable
device pci 02.1 alias gpp_bridge_0_7_a off end
device pci 02.2 alias gpp_bridge_0_8_a off end
- device pci 03.0 on end # Dummy Host Bridge, do not disable
+ device pci 03.0 on end # Dummy device function, do not disable
device pci 03.1 alias gpp_bridge_0_0_b off end
device pci 03.2 alias gpp_bridge_0_1_b off end
device pci 03.3 alias gpp_bridge_0_2_b off end
@@ -31,17 +31,17 @@ chip soc/amd/genoa
device pci 03.6 alias gpp_bridge_0_5_b off end
device pci 03.7 alias gpp_bridge_0_6_b off end
- device pci 04.0 on end # Dummy Host Bridge, do not disable
+ device pci 04.0 on end # Dummy device function, do not disable
device pci 04.1 alias gpp_bridge_0_7_b off end
device pci 04.2 alias gpp_bridge_0_8_b off end
- device pci 05.0 on end # Dummy Host Bridge, do not disable
+ device pci 05.0 on end # Dummy device function, do not disable
device pci 05.1 alias gpp_bridge_0_0_c off end
device pci 05.2 alias gpp_bridge_0_1_c off end
device pci 05.3 alias gpp_bridge_0_2_c off end
device pci 05.4 alias gpp_bridge_0_3_c off end
- device pci 07.0 on end # Dummy Host Bridge, do not disable
+ device pci 07.0 on end # Dummy device function, do not disable
device pci 07.1 alias gpp_bridge_0_a off # Internal GPP Bridge 0 to Bus B0
device pci 0.0 off end # Dummy PCIe function
device pci 0.1 off end
@@ -77,7 +77,7 @@ chip soc/amd/genoa
device pci 00.2 alias iommu_1 on ops amd_iommu_ops end
device pci 00.3 alias rcec_1 off end
- device pci 01.0 on end # Dummy Host Bridge, do not disable
+ device pci 01.0 on end # Dummy device function, do not disable
device pci 01.1 alias gpp_bridge_1_0_a off end
device pci 01.2 alias gpp_bridge_1_1_a off end
device pci 01.3 alias gpp_bridge_1_2_a off end
@@ -86,11 +86,11 @@ chip soc/amd/genoa
device pci 01.6 alias gpp_bridge_1_5_a off end
device pci 01.7 alias gpp_bridge_1_6_a off end
- device pci 02.0 on end # Dummy Host Bridge, do not disable
+ device pci 02.0 on end # Dummy device function, do not disable
device pci 02.1 alias gpp_bridge_1_7_a off end
device pci 02.2 alias gpp_bridge_1_8_a off end
- device pci 03.0 on end # Dummy Host Bridge, do not disable
+ device pci 03.0 on end # Dummy device function, do not disable
device pci 03.1 alias gpp_bridge_1_0_b off end
device pci 03.2 alias gpp_bridge_1_1_b off end
device pci 03.3 alias gpp_bridge_1_2_b off end
@@ -99,13 +99,13 @@ chip soc/amd/genoa
device pci 03.6 alias gpp_bridge_1_5_b off end
device pci 03.7 alias gpp_bridge_1_6_b off end
- device pci 04.0 on end # Dummy Host Bridge, do not disable
+ device pci 04.0 on end # Dummy device function, do not disable
device pci 04.1 alias gpp_bridge_1_7_b off end
device pci 04.2 alias gpp_bridge_1_8_b off end
- device pci 05.0 on end # Dummy Host Bridge, do not disable
+ device pci 05.0 on end # Dummy device function, do not disable
- device pci 07.0 on end # Dummy Host Bridge, do not disable
+ device pci 07.0 on end # Dummy device function, do not disable
device pci 07.1 alias gpp_bridge_1_a off
device pci 0.0 off end # Dummy PCIe function
device pci 0.1 off end #SDXI
@@ -118,7 +118,7 @@ chip soc/amd/genoa
device pci 00.2 alias iommu_2 on ops amd_iommu_ops end
device pci 00.3 alias rcec_2 off end
- device pci 01.0 on end # Dummy Host Bridge, do not disable
+ device pci 01.0 on end # Dummy device function, do not disable
device pci 01.1 alias gpp_bridge_2_0_a off end
device pci 01.2 alias gpp_bridge_2_1_a off end
device pci 01.3 alias gpp_bridge_2_2_a off end
@@ -127,11 +127,11 @@ chip soc/amd/genoa
device pci 01.6 alias gpp_bridge_2_5_a off end
device pci 01.7 alias gpp_bridge_2_6_a off end
- device pci 02.0 on end # Dummy Host Bridge, do not disable
+ device pci 02.0 on end # Dummy device function, do not disable
device pci 02.1 alias gpp_bridge_2_7_a off end
device pci 02.2 alias gpp_bridge_2_8_a off end
- device pci 03.0 on end # Dummy Host Bridge, do not disable
+ device pci 03.0 on end # Dummy device function, do not disable
device pci 03.1 alias gpp_bridge_2_0_b off end
device pci 03.2 alias gpp_bridge_2_1_b off end
device pci 03.3 alias gpp_bridge_2_2_b off end
@@ -140,13 +140,13 @@ chip soc/amd/genoa
device pci 03.6 alias gpp_bridge_2_5_b off end
device pci 03.7 alias gpp_bridge_2_6_b off end
- device pci 04.0 on end # Dummy Host Bridge, do not disable
+ device pci 04.0 on end # Dummy device function, do not disable
device pci 04.1 alias gpp_bridge_2_7_b off end
device pci 04.2 alias gpp_bridge_2_8_b off end
- device pci 05.0 on end # Dummy Host Bridge, do not disable
+ device pci 05.0 on end # Dummy device function, do not disable
- device pci 07.0 on end # Dummy Host Bridge, do not disable
+ device pci 07.0 on end # Dummy device function, do not disable
device pci 07.1 alias gpp_bridge_2_a off
device pci 0.0 off end # Dummy PCIe function
device pci 0.1 off end
@@ -159,7 +159,7 @@ chip soc/amd/genoa
device pci 00.2 alias iommu_3 on ops amd_iommu_ops end
device pci 00.3 alias rcec_3 off end
- device pci 01.0 on end # Dummy Host Bridge, do not disable
+ device pci 01.0 on end # Dummy device function, do not disable
device pci 01.1 alias gpp_bridge_3_0_a off end
device pci 01.2 alias gpp_bridge_3_1_a off end
device pci 01.3 alias gpp_bridge_3_2_a off end
@@ -168,11 +168,11 @@ chip soc/amd/genoa
device pci 01.6 alias gpp_bridge_3_5_a off end
device pci 01.7 alias gpp_bridge_3_6_a off end
- device pci 02.0 on end # Dummy Host Bridge, do not disable
+ device pci 02.0 on end # Dummy device function, do not disable
device pci 02.1 alias gpp_bridge_3_7_a off end
device pci 02.2 alias gpp_bridge_3_8_a off end
- device pci 03.0 on end # Dummy Host Bridge, do not disable
+ device pci 03.0 on end # Dummy device function, do not disable
device pci 03.1 alias gpp_bridge_3_0_b off end
device pci 03.2 alias gpp_bridge_3_1_b off end
device pci 03.3 alias gpp_bridge_3_2_b off end
@@ -181,17 +181,17 @@ chip soc/amd/genoa
device pci 03.6 alias gpp_bridge_3_5_b off end
device pci 03.7 alias gpp_bridge_3_6_b off end
- device pci 04.0 on end # Dummy Host Bridge, do not disable
+ device pci 04.0 on end # Dummy device function, do not disable
device pci 04.1 alias gpp_bridge_3_7_b off end
device pci 04.2 alias gpp_bridge_3_8_b off end
- device pci 05.0 on end # Dummy Host Bridge, do not disable
+ device pci 05.0 on end # Dummy device function, do not disable
device pci 05.1 alias gpp_bridge_3_0_c off end
device pci 05.2 alias gpp_bridge_3_1_c off end
device pci 05.3 alias gpp_bridge_3_2_c off end
device pci 05.4 alias gpp_bridge_3_3_c off end
- device pci 07.0 on end # Dummy Host Bridge, do not disable
+ device pci 07.0 on end # Dummy device function, do not disable
device pci 07.1 alias gpp_bridge_3_a off
device pci 0.0 off end # Dummy PCIe function
device pci 0.1 off end #SDXI