summaryrefslogtreecommitdiff
path: root/src/soc/amd/common
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2023-04-08 00:46:30 +0300
committerKyösti Mälkki <kyosti.malkki@gmail.com>2023-04-27 03:12:04 +0000
commit7186e28001ff01e9f48f838eab8ee462c3e8155c (patch)
treec6b95a2f5152b5831c9570835536ea3c04efa0fc /src/soc/amd/common
parent7971e7940c8f034c0b23723ec7ac520f63d69003 (diff)
soc/amd: Drop acpi_fill_madt_irqoverride()
It is unused. The use of field irq is problematic as it should appear relative to IOAPIC GSI bases in the devicetree. Change-Id: I460fd5fde3a7fba5518ccfc153a266d097a95a39 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/74357 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Diffstat (limited to 'src/soc/amd/common')
-rw-r--r--src/soc/amd/common/block/acpi/tables.c21
-rw-r--r--src/soc/amd/common/block/include/amdblocks/acpi.h1
-rw-r--r--src/soc/amd/common/block/include/amdblocks/chip.h11
3 files changed, 0 insertions, 33 deletions
diff --git a/src/soc/amd/common/block/acpi/tables.c b/src/soc/amd/common/block/acpi/tables.c
index 3ba9af6499..aaa851e0ac 100644
--- a/src/soc/amd/common/block/acpi/tables.c
+++ b/src/soc/amd/common/block/acpi/tables.c
@@ -16,27 +16,6 @@ unsigned long southbridge_write_acpi_tables(const struct device *device,
return acpi_write_hpet(device, current, rsdp);
}
-unsigned long acpi_fill_madt_irqoverride(unsigned long current)
-{
- const struct soc_amd_common_config *cfg = soc_get_common_config();
- unsigned int i;
- uint8_t irq;
- uint8_t flags;
-
- for (i = 0; i < ARRAY_SIZE(cfg->irq_override); ++i) {
- irq = cfg->irq_override[i].irq;
- flags = cfg->irq_override[i].flags;
-
- if (!flags)
- continue;
-
- current += acpi_create_madt_irqoverride((acpi_madt_irqoverride_t *)current, 0,
- irq, irq, flags);
- }
-
- return current;
-}
-
/* Used by \_SB.PCI0._CRS */
void acpi_fill_root_complex_tom(const struct device *device)
{
diff --git a/src/soc/amd/common/block/include/amdblocks/acpi.h b/src/soc/amd/common/block/include/amdblocks/acpi.h
index 9ffcb7e746..91051841f5 100644
--- a/src/soc/amd/common/block/include/amdblocks/acpi.h
+++ b/src/soc/amd/common/block/include/amdblocks/acpi.h
@@ -54,7 +54,6 @@ struct chipset_power_state {
unsigned long southbridge_write_acpi_tables(const struct device *device, unsigned long current,
struct acpi_rsdp *rsdp);
-unsigned long acpi_fill_madt_irqoverride(unsigned long current);
void acpi_fill_root_complex_tom(const struct device *device);
uintptr_t add_agesa_fsp_acpi_table(guid_t guid, const char *name, acpi_rsdp_t *rsdp,
diff --git a/src/soc/amd/common/block/include/amdblocks/chip.h b/src/soc/amd/common/block/include/amdblocks/chip.h
index 46662fc596..41359239ca 100644
--- a/src/soc/amd/common/block/include/amdblocks/chip.h
+++ b/src/soc/amd/common/block/include/amdblocks/chip.h
@@ -27,17 +27,6 @@ struct soc_amd_common_config {
uint16_t fadt_boot_arch;
uint32_t fadt_flags;
- /**
- * IRQ 0 - 15 have a default trigger of edge and default polarity of high.
- * If you have a device that requires a different configuration you can override the
- * settings here.
- */
- struct {
- uint8_t irq;
- /* See MP_IRQ_* from acpi.h */
- uint8_t flags;
- } irq_override[16];
-
/* Audio Co-processor (ACP) configuration */
struct acp_config acp_config;
};