diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2021-02-18 20:34:21 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2021-02-19 23:13:56 +0000 |
| commit | f1eaa672211b1623e206ae1b0f17b07ae53a7bee (patch) | |
| tree | 5cd9c48b7fcfd8e3d9dd04b0d2c9cf97287f1ccd /src/soc/amd/common | |
| parent | 746f438ada87ba4219f67355b3ce73b177914fca (diff) | |
soc/amd/common/block/data_fabric: add warning about broadcast reads
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: If1b65ae3dd2b5c8fe7bc29a267d108e4d3a3e567
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50883
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/amd/common')
| -rw-r--r-- | src/soc/amd/common/block/data_fabric/data_fabric_helper.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/soc/amd/common/block/data_fabric/data_fabric_helper.c b/src/soc/amd/common/block/data_fabric/data_fabric_helper.c index 27fc03d58c..abb4ba8c3a 100644 --- a/src/soc/amd/common/block/data_fabric/data_fabric_helper.c +++ b/src/soc/amd/common/block/data_fabric/data_fabric_helper.c @@ -23,6 +23,8 @@ static void data_fabric_set_indirect_address(uint8_t func, uint16_t reg, uint8_t uint32_t data_fabric_read32(uint8_t function, uint16_t reg, uint8_t instance_id) { + /* Broadcast reads might return unexpected results when a register has different + contents in the different instances. */ if (instance_id == BROADCAST_FABRIC_ID) return data_fabric_broadcast_read32(function, reg); |