summaryrefslogtreecommitdiff
path: root/src/soc/amd/common
diff options
context:
space:
mode:
authorMarc Jones <marcj303@gmail.com>2017-10-11 20:20:49 -0600
committerMartin Roth <martinroth@google.com>2017-10-13 16:48:33 +0000
commit4f886cc19a7e348bf4b996ec50890901ffbc49eb (patch)
tree01b8a04ca652b01642e4e2056615300a87d49c7c /src/soc/amd/common
parent3918887c1829fa0c4ccd18a95f3c26e92fad330c (diff)
amd/stoneyridge: Make all AGESA reset requests immediate
The AGESA RESET_WHENEVER request were never doing a reset in coreboot. We don't have a way to collect a whenever and reset at some later time, so just do the reset immediately. BUG=b:64719937 BRANCH=none TEST=Check AGESA reset request in booblock does a reset in the serial console or ec console. Change-Id: If2654ec0c5c5dbdcea6fc9374371c3388d29fdc7 Signed-off-by: Marc Jones <marcj303@gmail.com> Reviewed-on: https://review.coreboot.org/21978 Reviewed-by: Martin Roth <martinroth@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/amd/common')
-rw-r--r--src/soc/amd/common/def_callouts.c11
1 files changed, 4 insertions, 7 deletions
diff --git a/src/soc/amd/common/def_callouts.c b/src/soc/amd/common/def_callouts.c
index 4b71d5b105..fe0d5497e1 100644
--- a/src/soc/amd/common/def_callouts.c
+++ b/src/soc/amd/common/def_callouts.c
@@ -67,17 +67,14 @@ AGESA_STATUS agesa_Reset(UINT32 Func, UINTN Data, VOID *ConfigPtr)
ResetType = Data;
StdHeader = ConfigPtr;
- /* Perform the RESET based upon the ResetType. In case of
- * WARM_RESET_WHENEVER and COLD_RESET_WHENEVER, the request will go to
- * AmdResetManager. During the critical condition, where reset is
- * required immediately, the reset will be invoked directly by writing
- * 0x04 to port 0xCF9 (Reset Port).
+ /*
+ * This should perform the RESET based upon the ResetType, but coreboot
+ * doesn't have a reset manager to handle a WHENEVER case. Do all
+ * resets immediately.
*/
switch (ResetType) {
case WARM_RESET_WHENEVER:
case COLD_RESET_WHENEVER:
- break;
-
case WARM_RESET_IMMEDIATELY:
case COLD_RESET_IMMEDIATELY:
Value = 0x06;