diff options
| author | Marshall Dawson <marshalldawson3rd@gmail.com> | 2019-05-21 17:11:30 -0600 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2019-06-06 19:59:37 +0000 |
| commit | 08462ce590009c951f0458e6303b97bebe759101 (patch) | |
| tree | 3d810984131fca0dfdc1f6ebef798244f644948f /src/soc/amd/common/block/acpimmio | |
| parent | 59fbe89530c5e461916f3e40204605d27a59d4e4 (diff) | |
soc/amd/common: Update AcpiMmio comments
Document the AcpiMmio individual blocks better. This is in response
to a request in gerrit for
69486cac7: Create AcpiMmio functionality from stoneyridge
Correct comments that were inadvertently left in place from older
patches.
Change-Id: I4c16a866de5622e8cfbd3a08816b9d3182950d0e
Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32931
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/amd/common/block/acpimmio')
| -rw-r--r-- | src/soc/amd/common/block/acpimmio/mmio_util.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/soc/amd/common/block/acpimmio/mmio_util.c b/src/soc/amd/common/block/acpimmio/mmio_util.c index 281880cc25..d6320d69d8 100644 --- a/src/soc/amd/common/block/acpimmio/mmio_util.c +++ b/src/soc/amd/common/block/acpimmio/mmio_util.c @@ -214,7 +214,7 @@ void acpi_write32(u8 reg, u32 value) write32((void *)(ACPIMMIO_ACPI_BASE + reg), value); } -/* asf read/write - access registers at 0xfed80900 - not currently used */ +/* asf read/write - access registers at 0xfed80900 */ u8 asf_read8(u8 reg) { @@ -236,7 +236,7 @@ void asf_write16(u8 reg, u16 value) write16((void *)(ACPIMMIO_ASF_BASE + reg), value); } -/* smbus read/write - access registers at 0xfed80a00 and ASF at 0xfed80900 */ +/* smbus read/write - access registers at 0xfed80a00 */ u8 smbus_read8(u8 reg) { @@ -364,9 +364,9 @@ void xhci_pm_write32(uint8_t reg, uint32_t value) write32((void *)(ACPIMMIO_XHCIPM_BASE + reg), value); } -/* acdc_tmr read/write - access registers at 0xfed81d00 */ +/* acdc_tmr read/write - access registers at 0xfed81d00 - not currently used */ -/* aoac read/write - access registers at 0xfed81e00 - not currently used */ +/* aoac read/write - access registers at 0xfed81e00 */ u8 aoac_read8(u8 reg) { |