aboutsummaryrefslogtreecommitdiff
path: root/src/soc/amd/cezanne
diff options
context:
space:
mode:
authorMatt Papageorge <matthewpapa07@gmail.com>2021-07-20 15:09:46 -0500
committerFelix Held <felix-coreboot@felixheld.de>2021-07-24 19:49:45 +0000
commit5a2feeda39dfc5090c3a3d3bf5e4d8c0af3c650d (patch)
tree30515e62c6ee741960c05fa33ef43e4a22948b05 /src/soc/amd/cezanne
parent8baa9dfe1e51b8f00569b8be6d799bf3c2ed53ea (diff)
soc/amd/*/chip.h: Correct PSPP Enum Value
It appears the pspp_policy enum is not the same as the FSP definition currently being used. This means that the incorrect PSPP value setting would get read by FSP. For Zork programs this meant we actually were setting links as DXIO_PSPP_BALANCED instead of DXIO_PSPP_POWERSAVE. This change adds DXIO_PSPP_DISABLED as the first enum value to properly match the FSP definition and adjusts non AMD Customer Reference Boards that reference the enum to still send the same value even though it has now change definitions. If we actually want DXIO_PSPP_POWERSAVE for those boards that can be adjusted in a future change. BUG=b:193495634 TEST=Boot to OS with Majolica and Guybrush and run 10G iperf on wifi with other server on local network. Change-Id: I287b6d3168697793a2ae8d8e68b4ec824f2ca5ef Signed-off-by: Matt Papageorge <matthewpapa07@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/56463 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
Diffstat (limited to 'src/soc/amd/cezanne')
-rw-r--r--src/soc/amd/cezanne/chip.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/soc/amd/cezanne/chip.h b/src/soc/amd/cezanne/chip.h
index 319ce4108e..850d1bbbda 100644
--- a/src/soc/amd/cezanne/chip.h
+++ b/src/soc/amd/cezanne/chip.h
@@ -97,7 +97,8 @@ struct soc_amd_cezanne_config {
/* performance policy for the PCIe links: power consumption vs. link speed */
enum {
- DXIO_PSPP_PERFORMANCE = 0,
+ DXIO_PSPP_DISABLED = 0,
+ DXIO_PSPP_PERFORMANCE,
DXIO_PSPP_BALANCED,
DXIO_PSPP_POWERSAVE,
} pspp_policy;