diff options
| author | Arthur Heymans <arthur@aheymans.xyz> | 2024-08-22 23:16:57 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2024-08-29 13:58:21 +0000 |
| commit | aa75ee1a71719160608611f1ea81a399ef0d875d (patch) | |
| tree | 8e92b24bda9220320bf2ddd5f24ab35e1a59b00b /src/security | |
| parent | 86dadcd52aaf0db59d4f770a6ff8527ed681e86e (diff) | |
cbmem.h: Change return type of cbmem_get_region
The underlying IMD function already returns an integer which indicates
success or failure.
This removes the need to have initialized variables that need to be
checked for NULL later. In some cases this actually adds the appropriate
check for returned values.
Dying is appropriate if cbmem is not found as it is essential to the
bootflow.
Change-Id: Ib3e09a75380faf9f533601368993261f042422ef
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84039
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/security')
| -rw-r--r-- | src/security/memory/memory_clear.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/security/memory/memory_clear.c b/src/security/memory/memory_clear.c index 9af3205b0e..9a8a23a1f7 100644 --- a/src/security/memory/memory_clear.c +++ b/src/security/memory/memory_clear.c @@ -74,12 +74,13 @@ static void clear_memory(void *unused) BM_MEM_RAM); /* Add reserved entries */ - void *baseptr = NULL; - size_t size = 0; + void *baseptr; + size_t size; /* Only skip CBMEM, stage program, stack and heap are included there. */ - cbmem_get_region(&baseptr, &size); + if (cbmem_get_region(&baseptr, &size)) + die("Could not find cbmem region"); memranges_insert(&mem, (uintptr_t)baseptr, size, BM_MEM_TABLE); if (ENV_X86) { |