summaryrefslogtreecommitdiff
path: root/src/northbridge
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2020-10-23 11:00:14 +0200
committerAngel Pons <th3fanbus@gmail.com>2020-10-24 20:47:17 +0000
commit8cc39a5fae28c02d344b2401bb489898f369929f (patch)
tree4ebe9106062e999270e8631f3ed1147118c4c5e9 /src/northbridge
parent97f0d81503be2053a544e80b61732ff5d5479ef0 (diff)
nb/intel/haswell/finalize.c: Lock down MC ARB register
The Haswell System Agent BIOS Spec revision 0.6.0 indicates this register needs to be locked, and Broadwell already locks it. Tested on Asrock B85M Pro4, still boots and register is locked. Change-Id: Icdeb39e2fdde1403b6ab83faed214addca863f4b Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/46680 Reviewed-by: Nico Huber <nico.h@gmx.de> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/northbridge')
-rw-r--r--src/northbridge/intel/haswell/finalize.c1
-rw-r--r--src/northbridge/intel/haswell/registers/mchbar.h1
2 files changed, 2 insertions, 0 deletions
diff --git a/src/northbridge/intel/haswell/finalize.c b/src/northbridge/intel/haswell/finalize.c
index efbaf68074..1c83110a60 100644
--- a/src/northbridge/intel/haswell/finalize.c
+++ b/src/northbridge/intel/haswell/finalize.c
@@ -24,6 +24,7 @@ void intel_northbridge_haswell_finalize_smm(void)
MCHBAR32_OR(REQLIM, 1UL << 31);
MCHBAR32_OR(DMIVCLIM, 1UL << 31);
MCHBAR32_OR(CRDTLCK, 1 << 0);
+ MCHBAR32_OR(MCARBLCK, 1 << 0);
/* Memory Controller Lockdown */
MCHBAR8(MC_LOCK) = 0x8f;
diff --git a/src/northbridge/intel/haswell/registers/mchbar.h b/src/northbridge/intel/haswell/registers/mchbar.h
index bd99cee585..97ae433412 100644
--- a/src/northbridge/intel/haswell/registers/mchbar.h
+++ b/src/northbridge/intel/haswell/registers/mchbar.h
@@ -47,5 +47,6 @@
#define REQLIM 0x6800
#define DMIVCLIM 0x7000
#define CRDTLCK 0x77fc
+#define MCARBLCK 0x7ffc
#endif /* __HASWELL_REGISTERS_MCHBAR_H__ */