diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2020-07-03 23:52:34 +0200 |
|---|---|---|
| committer | Angel Pons <th3fanbus@gmail.com> | 2020-07-12 10:10:11 +0000 |
| commit | d37b7d89fd362242fd5da11303c7bb18bf78afcf (patch) | |
| tree | 12b4b962e423fb10816b848cb5a5143fd79fc84e /src/northbridge | |
| parent | 3ac92b7c93addd8e75096162f88e65a3a54fcab0 (diff) | |
haswell: Add function to retrieve SPD addresses
And use it instead of directly writing to the MRC struct.
Change-Id: I7f04db29a08512c1a8b2b2300dba71cb3b84a5c5
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43127
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tristan Corrick <tristan@corrick.kiwi>
Diffstat (limited to 'src/northbridge')
| -rw-r--r-- | src/northbridge/intel/haswell/raminit.h | 4 | ||||
| -rw-r--r-- | src/northbridge/intel/haswell/romstage.c | 3 |
2 files changed, 7 insertions, 0 deletions
diff --git a/src/northbridge/intel/haswell/raminit.h b/src/northbridge/intel/haswell/raminit.h index 140ea2088d..adf53ea4b4 100644 --- a/src/northbridge/intel/haswell/raminit.h +++ b/src/northbridge/intel/haswell/raminit.h @@ -3,11 +3,15 @@ #ifndef RAMINIT_H #define RAMINIT_H +#include <stdint.h> #include "pei_data.h" /* Optional function to copy SPD data for on-board memory */ void copy_spd(struct pei_data *peid); +/* Mainboard callback to fill in the SPD addresses in MRC format */ +void mb_get_spd_map(uint8_t spd_map[4]); + /* Necessary function to initialize pei_data with mainboard-specific settings */ void mainboard_fill_pei_data(struct pei_data *pei_data); diff --git a/src/northbridge/intel/haswell/romstage.c b/src/northbridge/intel/haswell/romstage.c index 40b7b879d1..2961299e7d 100644 --- a/src/northbridge/intel/haswell/romstage.c +++ b/src/northbridge/intel/haswell/romstage.c @@ -87,6 +87,9 @@ void mainboard_romstage_entry(void) /* MRC has hardcoded assumptions of 2 meaning S3 wake. Normalize it here. */ pei_data.boot_mode = wake_from_s3 ? 2 : 0; + /* Obtain the SPD addresses from mainboard code */ + mb_get_spd_map(pei_data.spd_addresses); + /* Calculate unimplemented DIMM slots for each channel */ pei_data.dimm_channel0_disabled = make_channel_disabled_mask(&pei_data, 0); pei_data.dimm_channel1_disabled = make_channel_disabled_mask(&pei_data, 1); |