diff options
author | Richard Spiegel <richard.spiegel@silverbackltd.com> | 2018-02-22 10:03:39 -0700 |
---|---|---|
committer | Patrick Georgi <pgeorgi@google.com> | 2018-02-26 15:06:58 +0000 |
commit | bd654805933f70ed77e5a03921c31262d9347cc6 (patch) | |
tree | c247fd21c86e4660868b55528578ad4025a88a2c /src/northbridge | |
parent | 99fd08d324c6a6da4149f95f9d78da0fc769c289 (diff) |
src/arch/x86/smbios.c: Fix type 17 part number
Some DIMMs have invalid strings when it comes to device part number
(bytes 0x149-0x15c). From DDR4 SPD specs it should be ASCIIZ with unused
space filled with white spaces (ASCII 0x20). Byte 20 should be 0 (ASCIIZ),
all others should be ASCII.
Create a test that detects invalid strings and replace invalid
characters with *. If a replacement was made the output string then must
be <Invalid (replaced string)>.
BUG=b:73122207
TEST=Build, boot and record serial output for kahlee while injecting
different strings to dmi17->PartNumber. Use code to examine SMBIOS,
while testing different valid and invalid strings.
Remove string injection before committing.
Change-Id: Iead2a4cb14ff28d263d7214111b637e62ebd2921
Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Reviewed-on: https://review.coreboot.org/23844
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to 'src/northbridge')
0 files changed, 0 insertions, 0 deletions