As Myles suggested a while back: Switch long time #warnings to be comments

only. Keeping them as #warnings will not likely that they're fixed.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>



git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5459 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

3 files changed, 11 insertions, 10 deletions

diff --git a/src/northbridge/amd/amdfam10/northbridge.c b/src/northbridge/amd/amdfam10/northbridge.c
index 76d85f6c3c..3d968a9ded 100644
--- a/src/northbridge/amd/amdfam10/northbridge.c
+++ b/src/northbridge/amd/amdfam10/northbridge.c
@@ -960,12 +960,14 @@ static void pci_domain_set_resources(device_t dev)
 		pci_tolm = find_pci_tolm(&dev->link[link], pci_tolm);
 	}
 
-#warning "FIXME handle interleaved nodes"
+	// FIXME handle interleaved nodes. If you fix this here, please fix
+	// amdk8, too.
 	mmio_basek = pci_tolm >> 10;
 	/* Round mmio_basek to something the processor can support */
 	mmio_basek &= ~((1 << 6) -1);
 
-#warning "FIXME improve mtrr.c so we don't use up all of the mtrrs with a 64M MMIO hole"
+	// FIXME improve mtrr.c so we don't use up all of the mtrrs with a 64M
+	// MMIO hole. If you fix this here, please fix amdk8, too.
 	/* Round the mmio hold to 64M */
 	mmio_basek &= ~((64*1024) - 1);
 
diff --git a/src/northbridge/amd/amdk8/northbridge.c b/src/northbridge/amd/amdk8/northbridge.c
index b6cc32426a..ed246ceff5 100644
--- a/src/northbridge/amd/amdk8/northbridge.c
+++ b/src/northbridge/amd/amdk8/northbridge.c
@@ -915,19 +915,18 @@ static void amdk8_domain_set_resources(device_t dev)
 	}
 #endif
 
-
 	pci_tolm = find_pci_tolm(&dev->link[0]);
 
-#warning "FIXME handle interleaved nodes"
+	// FIXME handle interleaved nodes. If you fix this here, please fix
+	// amdfam10, too.
 	mmio_basek = pci_tolm >> 10;
 	/* Round mmio_basek to something the processor can support */
 	mmio_basek &= ~((1 << 6) -1);
 
-#if 1
-#warning "FIXME improve mtrr.c so we don't use up all of the mtrrs with a 64M MMIO hole"
+	// FIXME improve mtrr.c so we don't use up all of the mtrrs with a 64M
+	// MMIO hole. If you fix this here, please fix amdfam10, too.
 	/* Round the mmio hole to 64M */
 	mmio_basek &= ~((64*1024) - 1);
-#endif
 
 #if CONFIG_HW_MEM_HOLE_SIZEK != 0
 	/* if the hw mem hole is already set in raminit stage, here we will compare mmio_basek and hole_basek
diff --git a/src/northbridge/amd/amdk8/raminit_f.c b/src/northbridge/amd/amdk8/raminit_f.c
index a959e7cc40..6872883416 100644
--- a/src/northbridge/amd/amdk8/raminit_f.c
+++ b/src/northbridge/amd/amdk8/raminit_f.c
@@ -1964,9 +1964,9 @@ static int get_dimm_Trc_clocks(u32 spd_device, const struct mem_param *param)
 	printk_raminit("update_dimm_Trc: clocks = %i\n", clocks);
 
 	if (clocks < DTL_TRC_MIN) {
-#warning We should die here or at least disable this bank.
-		printk(BIOS_NOTICE, "update_dimm_Trc: can't refresh fast enough, "
-			"want %i clocks, can %i clocks\n", clocks, DTL_TRC_MIN);
+		// We might want to die here instead or (at least|better) disable this bank.
+		printk(BIOS_NOTICE, "update_dimm_Trc: Can't refresh fast enough, "
+			"want %i clocks, minimum is %i clocks.\n", clocks, DTL_TRC_MIN);
 		clocks = DTL_TRC_MIN;
 	}
 	return clocks;