aboutsummaryrefslogtreecommitdiff
path: root/src/northbridge/intel/sandybridge/romstage.c
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2019-08-16 14:02:25 +0300
committerKyösti Mälkki <kyosti.malkki@gmail.com>2019-08-18 19:03:22 +0000
commit157b189f6b97b6e9ecd8d29edbbd045fbbc231f5 (patch)
tree4562bd212e40d0832fa893935d85a06d82f8a897 /src/northbridge/intel/sandybridge/romstage.c
parent146c09823333c52e8bbca98465ccc8512ec1daa2 (diff)
cpu/intel: Enter romstage without BIST
When entry to romstage is via cpu/intel/car/romstage.c BIST has not been passed down the path for sometime. Change-Id: I345975c53014902269cee21fc393331d33a84dce Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/34908 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/northbridge/intel/sandybridge/romstage.c')
-rw-r--r--src/northbridge/intel/sandybridge/romstage.c9
1 files changed, 2 insertions, 7 deletions
diff --git a/src/northbridge/intel/sandybridge/romstage.c b/src/northbridge/intel/sandybridge/romstage.c
index 2cef5f2605..bfcf79dd23 100644
--- a/src/northbridge/intel/sandybridge/romstage.c
+++ b/src/northbridge/intel/sandybridge/romstage.c
@@ -22,7 +22,6 @@
#include <cpu/x86/lapic.h>
#include <timestamp.h>
#include "sandybridge.h"
-#include <cpu/x86/bist.h>
#include <cpu/intel/romstage.h>
#include <device/pci_def.h>
#include <device/device.h>
@@ -44,15 +43,14 @@ static void early_pch_reset_pmcon(void)
/* Platform has no romstage entry point under mainboard directory,
* so this one is named with prefix mainboard.
*/
-void mainboard_romstage_entry(unsigned long bist)
+void mainboard_romstage_entry(void)
{
int s3resume = 0;
if (MCHBAR16(SSKPD) == 0xCAFE)
system_reset();
- if (bist == 0)
- enable_lapic();
+ enable_lapic();
/* Init LPC, GPIO, BARs, disable watchdog ... */
early_pch_init();
@@ -68,9 +66,6 @@ void mainboard_romstage_entry(unsigned long bist)
/* Initialize console device(s) */
console_init();
- /* Halt if there was a built in self test failure */
- report_bist_failure(bist);
-
/* Perform some early chipset initialization required
* before RAM initialization can work
*/