summaryrefslogtreecommitdiff
path: root/src/northbridge/intel/i945
diff options
context:
space:
mode:
authorElyes Haouas <ehaouas@noos.fr>2022-10-07 12:27:22 +0200
committerMartin L Roth <gaumless@gmail.com>2022-10-22 05:14:35 +0000
commit901566597e3afd0181571a4110e96902d93dd820 (patch)
treeea57c9653af61ac18402d12e5ebcc8befb5df393 /src/northbridge/intel/i945
parentd9dade3cb941a4564b827cfefdf154f974a18f1e (diff)
nb/intel/i945/raminit: Use 'bool' for do_reset
Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Change-Id: I692b86bba28853186185846f63dad1dcbfce1eea Reviewed-on: https://review.coreboot.org/c/coreboot/+/68217 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/northbridge/intel/i945')
-rw-r--r--src/northbridge/intel/i945/raminit.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c
index 47a37ce9a9..2613b81670 100644
--- a/src/northbridge/intel/i945/raminit.c
+++ b/src/northbridge/intel/i945/raminit.c
@@ -216,7 +216,7 @@ static int sdram_capabilities_core_frequencies(void)
static void sdram_detect_errors(struct sys_info *sysinfo)
{
u8 reg8;
- u8 do_reset = 0;
+ bool do_reset = false;
reg8 = pci_read_config8(PCI_DEV(0, 0x1f, 0), GEN_PMCON_2);
@@ -225,7 +225,7 @@ static void sdram_detect_errors(struct sys_info *sysinfo)
printk(BIOS_DEBUG, "SLP S4# Assertion Width Violation.\n");
/* Write back clears bit 2 */
pci_write_config8(PCI_DEV(0, 0x1f, 0), GEN_PMCON_2, reg8);
- do_reset = 1;
+ do_reset = true;
}
@@ -233,7 +233,7 @@ static void sdram_detect_errors(struct sys_info *sysinfo)
printk(BIOS_DEBUG, "DRAM initialization was interrupted.\n");
reg8 &= ~(1 << 7);
pci_write_config8(PCI_DEV(0, 0x1f, 0), GEN_PMCON_2, reg8);
- do_reset = 1;
+ do_reset = true;
}
/* Set SLP_S3# Assertion Stretch Enable */
@@ -258,12 +258,12 @@ static void sdram_detect_errors(struct sys_info *sysinfo)
if (((sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED) ||
(sysinfo->dimm[1] != SYSINFO_DIMM_NOT_POPULATED)) &&
!(mchbar_read8(SLFRCS) & (1 << 0))) {
- do_reset = 1;
+ do_reset = true;
}
if (((sysinfo->dimm[2] != SYSINFO_DIMM_NOT_POPULATED) ||
(sysinfo->dimm[3] != SYSINFO_DIMM_NOT_POPULATED)) &&
!(mchbar_read8(SLFRCS) & (1 << 1))) {
- do_reset = 1;
+ do_reset = true;
}
}