diff options
| author | Furquan Shaikh <furquan@google.com> | 2020-04-24 06:41:18 -0700 |
|---|---|---|
| committer | Furquan Shaikh <furquan@google.com> | 2020-04-28 19:21:49 +0000 |
| commit | 0f007d8ceb7e5c852c645cf773df5c5c37cbf411 (patch) | |
| tree | 2891d4d1b03e6a5b5d0695a88bc7272f849cb55e /src/northbridge/intel/haswell | |
| parent | f939df7a959b645cc79872623d72bed475c21157 (diff) | |
device: Constify struct device * parameter to write_acpi_tables
.write_acpi_tables() should not be updating the device structure. This
change makes the struct device * argument to it as const.
Change-Id: I50d013e83a404e0a0e3837ca16fa75c7eaa0e14a
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40701
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Diffstat (limited to 'src/northbridge/intel/haswell')
| -rw-r--r-- | src/northbridge/intel/haswell/acpi.c | 3 | ||||
| -rw-r--r-- | src/northbridge/intel/haswell/gma.c | 3 | ||||
| -rw-r--r-- | src/northbridge/intel/haswell/haswell.h | 2 |
3 files changed, 5 insertions, 3 deletions
diff --git a/src/northbridge/intel/haswell/acpi.c b/src/northbridge/intel/haswell/acpi.c index aa75e20bc1..f4d9d65421 100644 --- a/src/northbridge/intel/haswell/acpi.c +++ b/src/northbridge/intel/haswell/acpi.c @@ -93,7 +93,8 @@ static unsigned long acpi_fill_dmar(unsigned long current) return current; } -unsigned long northbridge_write_acpi_tables(struct device *const dev, unsigned long current, +unsigned long northbridge_write_acpi_tables(const struct device *const dev, + unsigned long current, struct acpi_rsdp *const rsdp) { /* Create DMAR table only if we have VT-d capability. */ diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c index c6b8fab65a..1014ce527c 100644 --- a/src/northbridge/intel/haswell/gma.c +++ b/src/northbridge/intel/haswell/gma.c @@ -520,7 +520,8 @@ static void gma_generate_ssdt(struct device *dev) drivers_intel_gma_displays_ssdt_generate(&chip->gfx); } -static unsigned long gma_write_acpi_tables(struct device *const dev, unsigned long current, +static unsigned long gma_write_acpi_tables(const struct device *const dev, + unsigned long current, struct acpi_rsdp *const rsdp) { igd_opregion_t *opregion = (igd_opregion_t *)current; diff --git a/src/northbridge/intel/haswell/haswell.h b/src/northbridge/intel/haswell/haswell.h index d5f7b32be5..32ac7c3db4 100644 --- a/src/northbridge/intel/haswell/haswell.h +++ b/src/northbridge/intel/haswell/haswell.h @@ -200,7 +200,7 @@ void report_platform_info(void); #include <device/device.h> struct acpi_rsdp; -unsigned long northbridge_write_acpi_tables(struct device *device, unsigned long start, +unsigned long northbridge_write_acpi_tables(const struct device *device, unsigned long start, struct acpi_rsdp *rsdp); #endif /* __ASSEMBLER__ */ |