diff options
author | Ryan Salsamendi <rsalsamendi@hotmail.com> | 2017-07-04 13:35:06 -0700 |
---|---|---|
committer | Nico Huber <nico.h@gmx.de> | 2017-07-06 20:20:12 +0000 |
commit | b9bc2571bebf05f9a295e80a66226064ef41b020 (patch) | |
tree | 1b600da94f5dd2cfb1aeed3f92816f929a62314d /src/northbridge/intel/haswell/early_init.c | |
parent | 70c27de57122558a0579ba7fb6517d55ed5bafc1 (diff) |
northbridge/intel/haswell: Fix undefined behavior
Fix undefined behavior found by clang's -Wshift-sign-overflow, grep,
and source inspection. Left shifting an int where the right operand is
>= the width of the type is undefined. Add UL suffix since it's safe
for unsigned types.
Change-Id: Id1ed2252ce3ed052730dd10b24c453c34c2ab4ff
Signed-off-by: Ryan Salsamendi <rsalsamendi@hotmail.com>
Reviewed-on: https://review.coreboot.org/20465
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/northbridge/intel/haswell/early_init.c')
-rw-r--r-- | src/northbridge/intel/haswell/early_init.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/northbridge/intel/haswell/early_init.c b/src/northbridge/intel/haswell/early_init.c index f4263394ad..a2b0f7fb88 100644 --- a/src/northbridge/intel/haswell/early_init.c +++ b/src/northbridge/intel/haswell/early_init.c @@ -81,7 +81,7 @@ static void haswell_setup_graphics(void) /* GPU RC6 workaround for sighting 366252 */ reg32 = MCHBAR32(0x5d14); - reg32 |= (1 << 31); + reg32 |= (1UL << 31); MCHBAR32(0x5d14) = reg32; /* VLW */ |