diff options
| author | Patrick Georgi <pgeorgi@chromium.org> | 2016-04-13 21:00:12 +0200 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2016-04-16 01:50:55 +0200 |
| commit | 59493717ad7aee5e4d6179b00c66b21af79e0376 (patch) | |
| tree | d3c9c27408c0499e4876fe366d695e6ecdec4842 /src/northbridge/amd/gx2/northbridgeinit.c | |
| parent | fab8ae77cb1a0fc078a4ddced50b3d30dec1df85 (diff) | |
northbridge/amd/{lx,gx2}: remove immediate accesses of 0
gcc doesn't like these because they're undefined behavior, so use
zeroptr instead. For the loop that just does a number of writes (0..4),
use zeroptr + i.
Checked the disassembly (AMD_RUMBA and PCENGINES_ALIX2D) to not contain
ud2 anymore and to look reasonable where zeroptr was used.
Change-Id: I4a58220ec9a10c465909ca4ecbe5366d0a8cc0df
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://review.coreboot.org/14345
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Tested-by: build bot (Jenkins)
Diffstat (limited to 'src/northbridge/amd/gx2/northbridgeinit.c')
| -rw-r--r-- | src/northbridge/amd/gx2/northbridgeinit.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/northbridge/amd/gx2/northbridgeinit.c b/src/northbridge/amd/gx2/northbridgeinit.c index 319d95a8ef..348cdb941c 100644 --- a/src/northbridge/amd/gx2/northbridgeinit.c +++ b/src/northbridge/amd/gx2/northbridgeinit.c @@ -656,7 +656,7 @@ void northbridge_init_early(void) /* Now that the descriptor to memory is set up. */ /* The memory controller needs one read to synch its lines before it can be used. */ - i = *(volatile int *) 0; + read32(zeroptr); GeodeLinkPriority(); |