summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2024-05-13 11:19:57 +0200
committerFelix Held <felix-coreboot@felixheld.de>2024-05-22 16:55:41 +0000
commitfa27d2dc2a34039421a8d5c1df342c19601f929f (patch)
tree377ecdcc853d9f4344fe0bfe10a6a26adcaca75d /src/mainboard
parent9251ddc27de5171f779e7729a4c8e9cfc8b76221 (diff)
mb/prodrive/hermes: Tidy up hda_verb.c
Use the `AZALIA_PIN_CFG_NC(0)` macro instead of `0x411111f0` and tidy up some comments (align them and be consistent with capitalisation). Tested with BUILD_TIMELESS=1, prodrive/hermes remains identical. Change-Id: I1ff1197b1309fc0e5b978d6d36867a3f1a68c67c Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/82396 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/prodrive/hermes/hda_verb.c36
1 files changed, 18 insertions, 18 deletions
diff --git a/src/mainboard/prodrive/hermes/hda_verb.c b/src/mainboard/prodrive/hermes/hda_verb.c
index 5876df5a2b..d1ad64f570 100644
--- a/src/mainboard/prodrive/hermes/hda_verb.c
+++ b/src/mainboard/prodrive/hermes/hda_verb.c
@@ -12,22 +12,22 @@ const u32 cim_verb_data[] = {
AZALIA_SUBVENDOR(0, 0x1d336700),
/* Pin widgets */
- AZALIA_PIN_CFG(0, 0x11, 0x411111f0), /* SPDIF-OUT2 - disabled */
- AZALIA_PIN_CFG(0, 0x12, 0x411111f0), /* digital MIC - disabled */
- AZALIA_PIN_CFG(0, 0x14, 0x01014430), /* PORT D - rear line out */
- AZALIA_PIN_CFG(0, 0x16, 0x411111f0), /* PORT G - disabled */
- AZALIA_PIN_CFG(0, 0x17, 0x411111f0), /* PORT H - disabled */
- AZALIA_PIN_CFG(0, 0x18, 0x01a19c50), /* PORT B - rear mic in */
- AZALIA_PIN_CFG(0, 0x1c, 0x411111f0), /* CD audio - disabled */
- AZALIA_PIN_CFG(0, 0x1d, 0x4004c601), /* BEEPIN */
- AZALIA_PIN_CFG(0, 0x1e, 0x01452160), /* SPDIF-OUT */
- AZALIA_PIN_CFG(0, 0x1f, 0x01c52170), /* SPDIF-IN */
+ AZALIA_PIN_CFG(0, 0x11, AZALIA_PIN_CFG_NC(0)), /* SPDIF-OUT2 - disabled */
+ AZALIA_PIN_CFG(0, 0x12, AZALIA_PIN_CFG_NC(0)), /* Digital MIC - disabled */
+ AZALIA_PIN_CFG(0, 0x14, 0x01014430), /* Port D - rear line out */
+ AZALIA_PIN_CFG(0, 0x16, AZALIA_PIN_CFG_NC(0)), /* Port G - disabled */
+ AZALIA_PIN_CFG(0, 0x17, AZALIA_PIN_CFG_NC(0)), /* Port H - disabled */
+ AZALIA_PIN_CFG(0, 0x18, 0x01a19c50), /* Port B - rear mic in */
+ AZALIA_PIN_CFG(0, 0x1c, AZALIA_PIN_CFG_NC(0)), /* CD audio - disabled */
+ AZALIA_PIN_CFG(0, 0x1d, 0x4004c601), /* BEEPIN */
+ AZALIA_PIN_CFG(0, 0x1e, 0x01452160), /* SPDIF-OUT */
+ AZALIA_PIN_CFG(0, 0x1f, 0x01c52170), /* SPDIF-IN */
/* Config for R02 and older */
- AZALIA_PIN_CFG(0, 0x19, 0x02214c40), /* port F - front hp out */
- AZALIA_PIN_CFG(0, 0x1a, 0x901001f0), /* port C - internal speaker */
- AZALIA_PIN_CFG(0, 0x1b, 0x01813c10), /* port E - rear line in/mic - Blue */
- AZALIA_PIN_CFG(0, 0x15, 0x02a19c20), /* port A - audio hdr input */
+ AZALIA_PIN_CFG(0, 0x19, 0x02214c40), /* Port F - front hp out */
+ AZALIA_PIN_CFG(0, 0x1a, 0x901001f0), /* Port C - internal speaker */
+ AZALIA_PIN_CFG(0, 0x1b, 0x01813c10), /* Port E - rear line in/mic - Blue */
+ AZALIA_PIN_CFG(0, 0x15, 0x02a19c20), /* Port A - audio hdr input */
/*
* VerbTable: CFL Display Audio Codec
@@ -67,10 +67,10 @@ const u32 pc_beep_verbs[0] = {};
AZALIA_ARRAY_SIZES;
static const u32 r04_verb_data[] = {
- AZALIA_PIN_CFG(0, 0x19, 0x02a19c20), /* PORT F - front mic in */
- AZALIA_PIN_CFG(0, 0x1a, 0x01813c51), /* PORT C - rear line in (mic support) */
- AZALIA_PIN_CFG(0, 0x1b, 0x411111f0), /* PORT E - disabled */
- AZALIA_PIN_CFG(0, 0x15, 0x411111f0), /* PORT A - disabled */
+ AZALIA_PIN_CFG(0, 0x19, 0x02a19c20), /* Port F - front mic in */
+ AZALIA_PIN_CFG(0, 0x1a, 0x01813c51), /* Port C - rear line in (mic support) */
+ AZALIA_PIN_CFG(0, 0x1b, AZALIA_PIN_CFG_NC(0)), /* Port E - disabled */
+ AZALIA_PIN_CFG(0, 0x15, AZALIA_PIN_CFG_NC(0)), /* Port A - disabled */
};
static u32 get_port_c_vref_cfg(uint8_t blue_rear_vref)