diff options
| author | Fred Reitberger <reitbergerfred@gmail.com> | 2022-09-01 16:13:38 -0400 |
|---|---|---|
| committer | Martin Roth <martin.roth@amd.corp-partner.google.com> | 2022-09-12 18:40:46 +0000 |
| commit | ef79e77c58b2c7003c1ef895b96a2ae57bdba49d (patch) | |
| tree | 672e52e7f043219f0638bcfa5255f8e578b87849 /src/mainboard | |
| parent | b366bcbd292dea098bf1eb82e3a768a2640d5ee3 (diff) | |
mb/google/skyrim/port_descriptors.c: Update ASPM configuration
Update ASPM configuration, disabling ASPM for the SSD due to s0i3
issues. Bug b:245550573 created to track the SSD issue.
TEST=Boot to OS and verify suspend via `suspend_stress_test -c 10`
BUG=b:243771794
Signed-off-by: Fred Reitberger <reitbergerfred@gmail.com>
Change-Id: I45a290c8ceddd39f65c6fe1390e3a753cad99899
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67304
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
Diffstat (limited to 'src/mainboard')
| -rw-r--r-- | src/mainboard/google/skyrim/port_descriptors.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/mainboard/google/skyrim/port_descriptors.c b/src/mainboard/google/skyrim/port_descriptors.c index ac64259bf6..808d00b5fe 100644 --- a/src/mainboard/google/skyrim/port_descriptors.c +++ b/src/mainboard/google/skyrim/port_descriptors.c @@ -15,7 +15,7 @@ static const fsp_dxio_descriptor skyrim_mdn_dxio_descriptors[] = { .function_number = PCI_FUNC(WLAN_DEVFN), .link_speed_capability = GEN3, .turn_off_unused_lanes = true, - .link_aspm = 2, + .link_aspm = ASPM_L1, .link_hotplug = 3, .clk_req = CLK_REQ2, }, @@ -28,6 +28,8 @@ static const fsp_dxio_descriptor skyrim_mdn_dxio_descriptors[] = { .function_number = PCI_FUNC(SD_DEVFN), .link_speed_capability = GEN3, .turn_off_unused_lanes = true, + .link_aspm = ASPM_L1, + .link_hotplug = 3, .gpio_group_id = GPIO_27, .clk_req = CLK_REQ1, }, @@ -40,7 +42,7 @@ static const fsp_dxio_descriptor skyrim_mdn_dxio_descriptors[] = { .function_number = PCI_FUNC(NVME_DEVFN), .link_speed_capability = GEN3, .turn_off_unused_lanes = true, - .link_aspm = 2, + .link_aspm = ASPM_DISABLED, // TODO: switch to ASPM_L1 after b:245550573 .link_hotplug = 3, .gpio_group_id = GPIO_6, .clk_req = CLK_REQ0, |