diff options
| author | Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com> | 2024-01-30 09:53:46 +0900 |
|---|---|---|
| committer | Felix Singer <service+coreboot-gerrit@felixsinger.de> | 2024-01-31 09:51:58 +0000 |
| commit | bfb11bec3b3fec638adf864a9b9b2cff6671fed8 (patch) | |
| tree | 0247c385cfbd79aa8496b1ddc3c3afcce1465616 /src/mainboard | |
| parent | f4c496d3e3e779b3d870d13e1e359a3b5f7087cb (diff) | |
include/device/device.h: Remove CHIP_NAME() macro
Macros can be confusing on their own; hiding commas make things worse.
This can sometimes be downright misleading. A "good" example would be
the code in soc/intel/xeon_sp/spr/chip.c:
CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev,
This appears as CHIP_NAME() being some struct when in fact these are
defining 2 separate members of the same struct.
It was decided to remove this macro altogether, as it does not do
anything special and incurs a maintenance burden.
Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Jakub Czapiga <czapiga@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Diffstat (limited to 'src/mainboard')
| -rw-r--r-- | src/mainboard/emulation/qemu-i440fx/northbridge.c | 4 | ||||
| -rw-r--r-- | src/mainboard/supermicro/x10slm-f/mainboard.c | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c index 5fe12e715d..6c26366ad7 100644 --- a/src/mainboard/emulation/qemu-i440fx/northbridge.c +++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c @@ -276,11 +276,11 @@ static void northbridge_enable(struct device *dev) } struct chip_operations mainboard_emulation_qemu_i440fx_ops = { - CHIP_NAME("QEMU Northbridge i440fx") + .name = "QEMU Northbridge i440fx", .enable_dev = northbridge_enable, }; struct chip_operations mainboard_emulation_qemu_q35_ops = { - CHIP_NAME("QEMU Northbridge q35") + .name = "QEMU Northbridge q35", .enable_dev = northbridge_enable, }; diff --git a/src/mainboard/supermicro/x10slm-f/mainboard.c b/src/mainboard/supermicro/x10slm-f/mainboard.c index 98548e33ba..37c1eb4dd8 100644 --- a/src/mainboard/supermicro/x10slm-f/mainboard.c +++ b/src/mainboard/supermicro/x10slm-f/mainboard.c @@ -35,6 +35,6 @@ static void mainboard_enable(struct device *dev) } struct chip_operations mainboard_ops = { - CHIP_NAME("X10SLM+-F") + .name = "X10SLM+-F", .enable_dev = mainboard_enable, }; |