diff options
| author | Nico Huber <nico.h@gmx.de> | 2018-11-11 02:51:14 +0100 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2019-01-09 22:15:48 +0000 |
| commit | a96e66a76f21c41b0c15db8d9df1d721f4a8a9af (patch) | |
| tree | 6cc4301dec4b2ca50a7c0fb43f92c60706bc7e14 /src/mainboard | |
| parent | 3910c4e4882876d70dfef08c6cc3946bc190d9ed (diff) | |
soc/intel: Clean mess around UART_DEBUG
Everything is wrong here, the Kconfig symbols are only the tip of the
iceberg. Based on Kconfig prompts the SoC code performed pad configu-
rations! I don't see why the person who configures coreboot should have
the board schematics at hand.
As a mitigation, we remove the prompts for UART_DEBUG, which is renamed
to INTEL_LPSS_UART_FOR_CONSOLE (because the former didn't really say
what it's about), and for UART_FOR_CONSOLE in case the former is selec-
ted.
Change-Id: Ibe2ed3cab0bb04bb23989c22da45299f088c758b
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/29573
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Diffstat (limited to 'src/mainboard')
| -rw-r--r-- | src/mainboard/intel/leafhill/Kconfig | 3 | ||||
| -rw-r--r-- | src/mainboard/intel/minnow3/Kconfig | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/src/mainboard/intel/leafhill/Kconfig b/src/mainboard/intel/leafhill/Kconfig index 94d0493953..69bfde764f 100644 --- a/src/mainboard/intel/leafhill/Kconfig +++ b/src/mainboard/intel/leafhill/Kconfig @@ -5,7 +5,7 @@ config BOARD_SPECIFIC_OPTIONS select SOC_INTEL_APOLLOLAKE select BOARD_ROMSIZE_KB_16384 select HAVE_ACPI_TABLES - select UART_DEBUG + select INTEL_LPSS_UART_FOR_CONSOLE config MAINBOARD_DIR string @@ -24,7 +24,6 @@ config FMDFILE default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/leafhill.$(CONFIG_COREBOOT_ROMSIZE_KB).fmd" config UART_FOR_CONSOLE - int "Number of UART port to use for serial log" default 2 config NEED_IFWI diff --git a/src/mainboard/intel/minnow3/Kconfig b/src/mainboard/intel/minnow3/Kconfig index 531036a6e3..a787a2d571 100644 --- a/src/mainboard/intel/minnow3/Kconfig +++ b/src/mainboard/intel/minnow3/Kconfig @@ -5,7 +5,7 @@ config BOARD_SPECIFIC_OPTIONS select SOC_INTEL_APOLLOLAKE select BOARD_ROMSIZE_KB_16384 select HAVE_ACPI_TABLES - select UART_DEBUG + select INTEL_LPSS_UART_FOR_CONSOLE config MAINBOARD_DIR string @@ -20,7 +20,6 @@ config FMDFILE default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/minnow3.fmd" config UART_FOR_CONSOLE - int "Number of UART port to use for serial log" default 2 config NEED_IFWI |