diff options
| author | Kevin Chang <kevin.chang@lcfc.corp-partner.google.com> | 2021-03-03 17:44:02 +0800 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2021-03-15 06:30:35 +0000 |
| commit | 80273918d5972157e6576ac983a14244d6074af1 (patch) | |
| tree | ff57154a4d57cb9b943410fa076ee40318ea0d4a /src/mainboard | |
| parent | 30cb21811b0dc89f0bfe15cfb37a855e44efea14 (diff) | |
mb/google/volteer/variant/lindar: Disable SA GV for Samsung memory with wrong date code MB
Disable SA GV, because factory used Samsung memory with wrong date code.
So we need to use board version to identify build MB phase to disable SA GV.
Disable SA GV when board version equal one.
BUG=b:179747696
BRANCH=firmware-volteer-13672.B
TEST=Built and booted into OS.
Signed-off-by: Kevin Chang <kevin.chang@lcfc.corp-partner.google.com>
Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f
Signed-off-by: Kevin Chang <kevin.chang@lcfc.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51200
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/mainboard')
3 files changed, 15 insertions, 0 deletions
diff --git a/src/mainboard/google/volteer/romstage.c b/src/mainboard/google/volteer/romstage.c index f3fb454eb3..8cde5da88b 100644 --- a/src/mainboard/google/volteer/romstage.c +++ b/src/mainboard/google/volteer/romstage.c @@ -22,4 +22,9 @@ void mainboard_memory_init_params(FSPM_UPD *mupd) bool half_populated = gpio_get(GPIO_MEM_CH_SEL); memcfg_init(mem_cfg, board_cfg, &spd_info, half_populated); + memcfg_variant_init(mupd); +} + +void __weak memcfg_variant_init(FSPM_UPD *mupd) +{ } diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h index 685440c0d2..ba4bf7febe 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h @@ -21,6 +21,7 @@ const struct cros_gpio *variant_cros_gpios(size_t *num); const struct mb_cfg *variant_memory_params(void); int variant_memory_sku(void); +void memcfg_variant_init(FSPM_UPD *mupd); /* Modify devictree settings during ramstage. */ void variant_devtree_update(void); diff --git a/src/mainboard/google/volteer/variants/lindar/memory.c b/src/mainboard/google/volteer/variants/lindar/memory.c index f9350d1471..6f61c1c9f9 100644 --- a/src/mainboard/google/volteer/variants/lindar/memory.c +++ b/src/mainboard/google/volteer/variants/lindar/memory.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <baseboard/variants.h> +#include <boardid.h> static const struct mb_cfg board_memcfg = { .type = MEM_TYPE_LP4X, @@ -59,3 +60,11 @@ const struct mb_cfg *variant_memory_params(void) { return &board_memcfg; } + +void memcfg_variant_init(FSPM_UPD *mupd) +{ + FSP_M_CONFIG *mem_cfg = &mupd->FspmConfig; + + if (board_id() == 1) + mem_cfg->SaGv = 0x00; +} |