summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorMatt DeVillier <matt.devillier@gmail.com>2022-12-21 12:23:03 -0600
committerFelix Singer <felixsinger@posteo.net>2023-01-09 21:10:19 +0000
commit7ab6ee6e716ef04077ad378c4adbd692fe43737f (patch)
tree702ca074b7769446d3201b44fb740966e34cef28 /src/mainboard
parent3d5475d66c74bf57f8c92c45ed0f9c9208681f2e (diff)
mb/google/dedede: Set touchscreen IRQs to LEVEL vs EDGE
The GPIOs themselves are configured as level triggered, and the drivers (both Linux and Windows) work better with LEVEL vs EDGE triggering. TEST=tested with rest of patch train Change-Id: I212533ffdfb05f841e722c130b52c2976272e670 Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/71188 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Singer <felixsinger@posteo.net>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/google/dedede/variants/cret/overridetree.cb2
-rw-r--r--src/mainboard/google/dedede/variants/galtic/overridetree.cb2
-rw-r--r--src/mainboard/google/dedede/variants/lalala/overridetree.cb4
-rw-r--r--src/mainboard/google/dedede/variants/magolor/overridetree.cb4
-rw-r--r--src/mainboard/google/dedede/variants/pirika/overridetree.cb2
5 files changed, 7 insertions, 7 deletions
diff --git a/src/mainboard/google/dedede/variants/cret/overridetree.cb b/src/mainboard/google/dedede/variants/cret/overridetree.cb
index c42f36a54d..9630e314c2 100644
--- a/src/mainboard/google/dedede/variants/cret/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/cret/overridetree.cb
@@ -179,7 +179,7 @@ chip soc/intel/jasperlake
chip drivers/i2c/generic
register "hid" = ""ELAN0001""
register "desc" = ""ELAN Touchscreen""
- register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)"
register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)"
register "reset_delay_ms" = "20"
diff --git a/src/mainboard/google/dedede/variants/galtic/overridetree.cb b/src/mainboard/google/dedede/variants/galtic/overridetree.cb
index 4e8b1a3206..fb554ce487 100644
--- a/src/mainboard/google/dedede/variants/galtic/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/galtic/overridetree.cb
@@ -163,7 +163,7 @@ chip soc/intel/jasperlake
chip drivers/i2c/generic
register "hid" = ""ELAN0001""
register "desc" = ""ELAN Touchscreen""
- register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)"
register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)"
register "reset_delay_ms" = "20"
diff --git a/src/mainboard/google/dedede/variants/lalala/overridetree.cb b/src/mainboard/google/dedede/variants/lalala/overridetree.cb
index de33d69909..5bfad2c736 100644
--- a/src/mainboard/google/dedede/variants/lalala/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/lalala/overridetree.cb
@@ -171,7 +171,7 @@ chip soc/intel/jasperlake
chip drivers/i2c/generic
register "hid" = ""ELAN0001""
register "desc" = ""ELAN Touchscreen""
- register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)"
register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)"
register "reset_delay_ms" = "20"
@@ -183,7 +183,7 @@ chip soc/intel/jasperlake
chip drivers/i2c/generic
register "hid" = ""RAYD0001""
register "desc" = ""Raydium Touchscreen""
- register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)"
register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)"
register "reset_delay_ms" = "100"
diff --git a/src/mainboard/google/dedede/variants/magolor/overridetree.cb b/src/mainboard/google/dedede/variants/magolor/overridetree.cb
index 6511e53f4b..a7e71c1200 100644
--- a/src/mainboard/google/dedede/variants/magolor/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/magolor/overridetree.cb
@@ -302,7 +302,7 @@ chip soc/intel/jasperlake
chip drivers/i2c/generic
register "hid" = ""ELAN0001""
register "desc" = ""ELAN Touchscreen""
- register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)"
register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)"
register "reset_delay_ms" = "20"
@@ -317,7 +317,7 @@ chip soc/intel/jasperlake
chip drivers/i2c/generic
register "hid" = ""RAYD0001""
register "desc" = ""Raydium Touchscreen""
- register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)"
register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)"
register "reset_delay_ms" = "100"
diff --git a/src/mainboard/google/dedede/variants/pirika/overridetree.cb b/src/mainboard/google/dedede/variants/pirika/overridetree.cb
index 1d27a5cade..a935325f28 100644
--- a/src/mainboard/google/dedede/variants/pirika/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/pirika/overridetree.cb
@@ -145,7 +145,7 @@ chip soc/intel/jasperlake
chip drivers/i2c/generic
register "hid" = ""ELAN0001""
register "desc" = ""ELAN Touchscreen""
- register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)"
register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)"
register "reset_delay_ms" = "20"