summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorMartin Roth <martin@coreboot.org>2020-05-05 11:09:51 -0600
committerMartin Roth <martinroth@google.com>2020-05-10 18:49:41 +0000
commit5ee19cda8136a877c9ec1433eb805b220c219c42 (patch)
tree3e7089c269c1e7b3c9703199dfb44e26dfc7e891 /src/mainboard
parentfbf3a47e429c4b6bbfd4ef6e9cc7eef1b9ed69e4 (diff)
mb/google/kahlee: Don't reset the touchpad/screen on boot
touchpad & touchscreen power enable gets reset during resume causing unintended wake interrupts, causing dark resume failures. This prevents the board from being shut down after it's been suspended for a long period of time and can end up draining the battery. BUG=b:153173717 TEST=Build only - Needs to be tested by ODMs. Signed-off-by: Martin Roth <martin@coreboot.org> Change-Id: If403da8853e59eaaf589062c9bd6f10deb626998 Reviewed-on: https://review.coreboot.org/c/coreboot/+/41063 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Kevin Chiu <Kevin.Chiu@quantatw.com>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/google/kahlee/variants/baseboard/gpio.c8
1 files changed, 0 insertions, 8 deletions
diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
index fe0744a62a..72db0a2d84 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c
+++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
@@ -26,10 +26,6 @@ static const struct soc_amd_gpio gpio_set_stage_reset[] = {
/* GPIO_15 - EC_IN_RW_OD */
PAD_GPI(GPIO_15, PULL_UP),
- /* GPIO_12 - EN_PP3300_TRACKPAD */
- /* Init low to reset the chip */
- PAD_GPO(GPIO_12, LOW),
-
/* GPIO_22 - EC_SCI_ODL, SCI */
PAD_SCI(GPIO_22, PULL_UP, EDGE_LOW),
@@ -45,10 +41,6 @@ static const struct soc_amd_gpio gpio_set_stage_reset[] = {
/* GPIO_74 - LPC_CLK0_EC_R */
PAD_NF(GPIO_74, LPCCLK0, PULL_DOWN),
- /* GPIO_76 - EN_PP3300_TOUCHSCREEN */
- /* Init low to reset the chip */
- PAD_GPO(GPIO_76, LOW),
-
/* GPIO_92 - WLAN_PCIE_CLKREQ_3V3_ODL */
PAD_NF(GPIO_92, CLK_REQ0_L, PULL_UP),