diff options
| author | Subrata Banik <subratabanik@google.com> | 2024-10-05 09:59:50 +0000 |
|---|---|---|
| committer | Martin L Roth <gaumless@gmail.com> | 2024-10-09 01:43:46 +0000 |
| commit | 073a713ace56a0b8ae09b223b74bbb8cdeaabfdd (patch) | |
| tree | 3f169b77e935b62797c929e7fb412887733e1d7a /src/mainboard | |
| parent | bd299aee380c3fb54d006672672f6e8443f1bca9 (diff) | |
mb/google/rex/var/ovis: Update EC event parameters for Ovis
This change updates the EC event parameters for Ovis, a Chromebox.
As a result, several existing parameters like LID, battery, and AC
connect/disconnect are no longer applicable to the Chromebox design.
TEST=Successfully built and booted google/ovis.
Change-Id: I2b9a6970a07624e16b4483907b8d2b77c04d535c
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84671
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard')
| -rw-r--r-- | src/mainboard/google/rex/variants/baseboard/ovis/include/baseboard/ec.h | 29 |
1 files changed, 5 insertions, 24 deletions
diff --git a/src/mainboard/google/rex/variants/baseboard/ovis/include/baseboard/ec.h b/src/mainboard/google/rex/variants/baseboard/ovis/include/baseboard/ec.h index 37c8a74318..d555c8a0bd 100644 --- a/src/mainboard/google/rex/variants/baseboard/ovis/include/baseboard/ec.h +++ b/src/mainboard/google/rex/variants/baseboard/ovis/include/baseboard/ec.h @@ -8,38 +8,22 @@ #include <baseboard/gpio.h> #define MAINBOARD_EC_SCI_EVENTS \ - (EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_CONNECTED) |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_DISCONNECTED) |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\ + (EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_MUX)) -#define MAINBOARD_EC_SMI_EVENTS \ - (EC_HOST_EVENT_NONE) +#define MAINBOARD_EC_SMI_EVENTS 0 /* EC can wake from S5 with power button */ #define MAINBOARD_EC_S5_WAKE_EVENTS \ (EC_HOST_EVENT_MASK(EC_HOST_EVENT_POWER_BUTTON)) -/* - * EC can wake from S3/S0ix with: - * 1. AC Connect/Disconnect - * 2. Power button - * 3. Key press - * 4. Mode change - */ -#define MAINBOARD_EC_S3_WAKE_EVENTS \ - (MAINBOARD_EC_S5_WAKE_EVENTS |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_CONNECTED) |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_DISCONNECTED) |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE) |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_CRITICAL) |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_SHUTDOWN)) +/* EC can wake from S3 with power button */ +#define MAINBOARD_EC_S3_WAKE_EVENTS (MAINBOARD_EC_S5_WAKE_EVENTS) #define MAINBOARD_EC_S0IX_WAKE_EVENTS \ (MAINBOARD_EC_S3_WAKE_EVENTS |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_MUX) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_MUX) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_HANG_DETECT)) /* Log EC wake events plus EC shutdown events */ #define MAINBOARD_EC_LOG_EVENTS \ @@ -48,8 +32,6 @@ /* * ACPI related definitions for ASL code. */ -/* Enable EC backed ALS device in ACPI */ -#define EC_ENABLE_ALS_DEVICE /* Enable MKBP for buttons and switches */ #define EC_ENABLE_MKBP_DEVICE #define EC_ENABLE_WAKE_PIN GPE_EC_WAKE @@ -57,7 +39,6 @@ #define EC_ENABLE_PD_MCU_DEVICE #define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ -#define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */ #define EC_ENABLE_SYNC_IRQ /* Enable tight timestamp / wake support */ #define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */ |