diff options
| author | Uwe Hermann <uwe@hermann-uwe.de> | 2009-10-09 11:47:21 +0000 |
|---|---|---|
| committer | Uwe Hermann <uwe@hermann-uwe.de> | 2009-10-09 11:47:21 +0000 |
| commit | 748475b800c552236aff16c1beffd55b70791ae6 (patch) | |
| tree | 340f14dfeb3cec4c1d7a89935efc526dd736fb89 /src/mainboard | |
| parent | ebb43d69439d847e87e18ac332e71b9b0476936a (diff) | |
More kconfig cleanups:
- Use "default n" for all components that shall be "select"ed.
- Use "0x0" instead of "0" for hex variables for clarity and to reduce
the risk of people passing integer instead of hex values to such variables.
- Add TODO comments for boards that have irq_tables.c but don' set
CONFIG_HAVE_PIRQ_TABLE = 1. Someone with the hardware should test enabling.
- ASUS M2V-MX SE doesn't have irq_tables.c so don't define
IRQ_SLOT_COUNT in its Kconfig file.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Myles Watson <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4749 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/mainboard')
| -rw-r--r-- | src/mainboard/asus/m2v-mx_se/Kconfig | 5 | ||||
| -rw-r--r-- | src/mainboard/iei/juki-511p/Options.lb | 2 | ||||
| -rw-r--r-- | src/mainboard/televideo/tc7020/Options.lb | 3 | ||||
| -rw-r--r-- | src/mainboard/via/epia-m700/Options.lb | 1 |
4 files changed, 3 insertions, 8 deletions
diff --git a/src/mainboard/asus/m2v-mx_se/Kconfig b/src/mainboard/asus/m2v-mx_se/Kconfig index 0a39eae9ce..f1ab0ffbc5 100644 --- a/src/mainboard/asus/m2v-mx_se/Kconfig +++ b/src/mainboard/asus/m2v-mx_se/Kconfig @@ -115,8 +115,3 @@ config HT_CHAIN_END_UNITID_BASE default 0x20 depends on BOARD_ASUS_M2V_MX_SE -# FIXME? -config IRQ_SLOT_COUNT - int - default 11 - depends on BOARD_ASUS_M2V_MX_SE diff --git a/src/mainboard/iei/juki-511p/Options.lb b/src/mainboard/iei/juki-511p/Options.lb index de0b1d2f21..16264f2754 100644 --- a/src/mainboard/iei/juki-511p/Options.lb +++ b/src/mainboard/iei/juki-511p/Options.lb @@ -69,10 +69,10 @@ default CONFIG_UDELAY_IO=1 ## ## Build code to export a programmable irq routing table ## +# FIXME: There's an irq_tables.c file, but CONFIG_HAVE_PIRQ_TABLE is 0. default CONFIG_HAVE_PIRQ_TABLE=0 default CONFIG_IRQ_SLOT_COUNT=2 default CONFIG_PIRQ_ROUTE=1 -#object irq_tables.o ## ## Build code to export a CMOS option table diff --git a/src/mainboard/televideo/tc7020/Options.lb b/src/mainboard/televideo/tc7020/Options.lb index 85f2928fd1..683b19b2ab 100644 --- a/src/mainboard/televideo/tc7020/Options.lb +++ b/src/mainboard/televideo/tc7020/Options.lb @@ -70,8 +70,6 @@ default CONFIG_GX1_VIDEO = 1 default CONFIG_GX1_VIDEOMODE = 0 default CONFIG_SPLASH_GRAPHIC = 1 default CONFIG_VIDEO_MB = 2 -default CONFIG_HAVE_PIRQ_TABLE=0 -default CONFIG_PIRQ_ROUTE=1 default CONFIG_ROM_SIZE = 256 * 1024 default CONFIG_MAINBOARD_VENDOR = "TeleVideo" @@ -82,6 +80,7 @@ default CONFIG_HAVE_HARD_RESET = 0 default CONFIG_UDELAY_TSC = 1 default CONFIG_TSC_X86RDTSC_CALIBRATE_WITH_TIMER2 = 1 default CONFIG_HAVE_PIRQ_TABLE = 1 +default CONFIG_PIRQ_ROUTE=1 default CONFIG_IRQ_SLOT_COUNT = 3 # Soldered NIC, internal USB, mini PCI slot default CONFIG_HAVE_OPTION_TABLE = 0 default CONFIG_ROM_IMAGE_SIZE = 64 * 1024 diff --git a/src/mainboard/via/epia-m700/Options.lb b/src/mainboard/via/epia-m700/Options.lb index d3e5d6d504..f88cd928f7 100644 --- a/src/mainboard/via/epia-m700/Options.lb +++ b/src/mainboard/via/epia-m700/Options.lb @@ -116,6 +116,7 @@ default CONFIG_HAVE_MP_TABLE = 0 default CONFIG_UDELAY_TSC = 1 default CONFIG_TSC_X86RDTSC_CALIBRATE_WITH_TIMER2 = 1 default CONFIG_HAVE_HARD_RESET = 0 +# TODO: There is an irq_tables.c file, should it be used? default CONFIG_HAVE_PIRQ_TABLE = 0 default CONFIG_IRQ_SLOT_COUNT = 13 default CONFIG_HAVE_ACPI_TABLES = 1 |