summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorFurquan Shaikh <furquan@chromium.org>2017-04-11 13:36:47 -0700
committerFurquan Shaikh <furquan@google.com>2017-04-13 05:05:05 +0200
commitbcbba801b8960a3885752521b112648a23b42cc9 (patch)
tree8297126bdb7f2301d9cfdc32f27b6748958fdc93 /src/mainboard
parent82010835bf6d19f3d679395cd2b28466a8bc12c7 (diff)
mainboard/google/poppy: Enable internal pull-down on USB_C{0,1}_DP_HPD
These lines act as inputs to both EC and AP. Thus, add internal pull-downs to prevent them from floating. BUG=b:35648530 Change-Id: I42326c810775d5449e99e52e81870970247ce335 Signed-off-by: Furquan Shaikh <furquan@chromium.org> Reviewed-on: https://review.coreboot.org/19243 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/google/poppy/gpio.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/google/poppy/gpio.h b/src/mainboard/google/poppy/gpio.h
index be7a488d5b..234d974e0b 100644
--- a/src/mainboard/google/poppy/gpio.h
+++ b/src/mainboard/google/poppy/gpio.h
@@ -162,9 +162,9 @@ static const struct pad_config gpio_table[] = {
NF1), /* USB_C1_OC_ODL */
/* USB2_OC2# */ PAD_CFG_GPO(GPP_E11, 0, DEEP), /* TOUCHSCREEN_RESET_L */
/* USB2_OC3# */ PAD_CFG_NF(GPP_E12, NONE, DEEP, NF1), /* USB2_OC3_L */
-/* DDPB_HPD0 */ PAD_CFG_NF(GPP_E13, NONE, DEEP,
+/* DDPB_HPD0 */ PAD_CFG_NF(GPP_E13, 20K_PD, DEEP,
NF1), /* USB_C0_DP_HPD */
-/* DDPC_HPD1 */ PAD_CFG_NF(GPP_E14, NONE, DEEP,
+/* DDPC_HPD1 */ PAD_CFG_NF(GPP_E14, 20K_PD, DEEP,
NF1), /* USB_C1_DP_HPD */
/* DDPD_HPD2 */ PAD_CFG_GPI(GPP_E15, 20K_PU, DEEP), /* SD_CD# */
/* DDPE_HPD3 */ PAD_CFG_NC(GPP_E16), /* TP244 */