summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorFurquan Shaikh <furquan@google.com>2020-07-21 22:54:16 -0700
committerFelix Held <felix-coreboot@felixheld.de>2020-07-23 14:11:27 +0000
commit7f892b51f466e4d3898310d527705bd0864ce8ae (patch)
tree5ac151716548b7aa9a53059127db27b488a8b8f6 /src/mainboard
parentfd4fbe8148dc4f18e13c2008466de50bb2966a64 (diff)
mb/google/zork: Drop TODO for GPIO_91
GPIO_91 is added to ACPI using the device tree entry for codec. So, this change drops the TODO from GPIO table. Change-Id: I9c2e91465ab554126531f8512028360ae5fb316d Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/43699 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c2
-rw-r--r--src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
index 26fd686554..f65a92eaa4 100644
--- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
+++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
@@ -107,7 +107,7 @@ static const struct soc_amd_gpio gpio_set_stage_ram[] = {
PAD_GPO(GPIO_89, HIGH),
/* RAM ID 1 */
PAD_GPI(GPIO_90, PULL_NONE),
- /* EN_SPKR TODO: Verify driver enables this (add to ACPI) */
+ /* EN_SPKR */
PAD_GPO(GPIO_91, LOW),
/* CLK_REQ0_L - WIFI */
PAD_NF(GPIO_92, CLK_REQ0_L, PULL_NONE),
diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
index f4af816bd1..55c66e6465 100644
--- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
+++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
@@ -113,7 +113,7 @@ static const struct soc_amd_gpio gpio_set_stage_ram[] = {
PAD_GPO(GPIO_89, HIGH),
/* Testpoint */
PAD_NC(GPIO_90),
- /* EN_SPKR TODO: Verify driver enables this (add to ACPI) */
+ /* EN_SPKR */
PAD_GPO(GPIO_91, LOW),
/* CLK_REQ0_L - WIFI */
PAD_NF(GPIO_92, CLK_REQ0_L, PULL_NONE),