summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorEricKY Cheng <ericky_cheng@compal.corp-partner.google.com>2022-10-28 16:26:06 +0800
committerFelix Held <felix-coreboot@felixheld.de>2022-11-03 12:55:53 +0000
commit4b1945ce581447f8623f4e4fb4c2ebfaf33b0eae (patch)
tree27366acf1dac3a474502c1a0a4f904d0bffadd1b /src/mainboard
parent96edc100c047e76c5baba816ffa26f3698c330e2 (diff)
mb/google/skyrim: Disable SD ASPM
Disable ASPM on SD until b/245550573 is root-caused/fixed. Logical_lane 1 on winterhold is EMMC device. Disable ASPM for suspend issue. BUG=b:249914847, b:245550573 TEST=emerge-skyrim coreboot chromeos-bootimage and test on whiterun proto emmc sku with suspend_stress_test -c 10 Change-Id: If080cdb517a3f22aa89c8053fb6bba9e931c6f76 Signed-off-by: EricKY Cheng <ericky_cheng@compal.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/68940 Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/google/skyrim/port_descriptors.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/google/skyrim/port_descriptors.c b/src/mainboard/google/skyrim/port_descriptors.c
index 91316b388c..c7b1a8b211 100644
--- a/src/mainboard/google/skyrim/port_descriptors.c
+++ b/src/mainboard/google/skyrim/port_descriptors.c
@@ -28,7 +28,7 @@ static const fsp_dxio_descriptor skyrim_mdn_dxio_descriptors[] = {
.function_number = PCI_FUNC(SD_DEVFN),
.link_speed_capability = GEN3,
.turn_off_unused_lanes = true,
- .link_aspm = ASPM_L1,
+ .link_aspm = ASPM_DISABLED, // TODO: switch to ASPM_L1 after b:245550573
.link_hotplug = 3,
.gpio_group_id = GPIO_27,
.clk_req = CLK_REQ1,