summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorMatt DeVillier <matt.devillier@amd.corp-partner.google.com>2022-11-14 10:11:38 -0600
committerEric Lai <eric_lai@quanta.corp-partner.google.com>2022-11-16 03:00:49 +0000
commit2c6bba3fe145cc9c9955b1ed55c42d58e06d55af (patch)
treee5f9c7dfaddc7f6c899e337e85298d97a30385f8 /src/mainboard
parentc7ec8f1d3cb38ca89ee1c59107c7496383c4e563 (diff)
mb/google/kahlee: Disable touchscreen GPIO export in CRS
Disable GPIO export in ACPI _CRS for touchscreens which set the register "have_power_resource." This eliminates the error: [ERROR] I2C: <bus:addr>: Exposing GPIOs in Power Resource and _CRS TEST=build/boot barla/liara, verify touchscreen functional, no error in cbmem log. Change-Id: Ifa8248755f346df37faf7a3182651bf190b0c33d Signed-off-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69549 Reviewed-by: Martin L Roth <gaumless@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/google/kahlee/variants/aleena/overridetree.cb1
-rw-r--r--src/mainboard/google/kahlee/variants/baseboard/devicetree.cb2
-rw-r--r--src/mainboard/google/kahlee/variants/careena/overridetree.cb1
-rw-r--r--src/mainboard/google/kahlee/variants/grunt/overridetree.cb1
-rw-r--r--src/mainboard/google/kahlee/variants/nuwani/overridetree.cb1
-rw-r--r--src/mainboard/google/kahlee/variants/treeya/overridetree.cb1
6 files changed, 7 insertions, 0 deletions
diff --git a/src/mainboard/google/kahlee/variants/aleena/overridetree.cb b/src/mainboard/google/kahlee/variants/aleena/overridetree.cb
index 357cbdcdcc..cdd3158fd3 100644
--- a/src/mainboard/google/kahlee/variants/aleena/overridetree.cb
+++ b/src/mainboard/google/kahlee/variants/aleena/overridetree.cb
@@ -56,6 +56,7 @@ chip soc/amd/stoneyridge
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_76)"
register "enable_delay_ms" = "1"
register "has_power_resource" = "1"
+ register "disable_gpio_export_in_crs" = "1"
device i2c 39 on end
end
end
diff --git a/src/mainboard/google/kahlee/variants/baseboard/devicetree.cb b/src/mainboard/google/kahlee/variants/baseboard/devicetree.cb
index fc74d77417..48c7928c04 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/baseboard/devicetree.cb
@@ -94,6 +94,7 @@ chip soc/amd/stoneyridge
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_76)"
register "enable_delay_ms" = "1"
register "has_power_resource" = "1"
+ register "disable_gpio_export_in_crs" = "1"
device i2c 39 on end
end
chip drivers/i2c/generic
@@ -106,6 +107,7 @@ chip soc/amd/stoneyridge
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_76)"
register "enable_delay_ms" = "1"
register "has_power_resource" = "1"
+ register "disable_gpio_export_in_crs" = "1"
device i2c 10 on end
end
end
diff --git a/src/mainboard/google/kahlee/variants/careena/overridetree.cb b/src/mainboard/google/kahlee/variants/careena/overridetree.cb
index 9e74990d00..37215ce0d8 100644
--- a/src/mainboard/google/kahlee/variants/careena/overridetree.cb
+++ b/src/mainboard/google/kahlee/variants/careena/overridetree.cb
@@ -66,6 +66,7 @@ chip soc/amd/stoneyridge
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_76)"
register "enable_delay_ms" = "1"
register "has_power_resource" = "1"
+ register "disable_gpio_export_in_crs" = "1"
device i2c 39 on end
end
chip drivers/i2c/hid
diff --git a/src/mainboard/google/kahlee/variants/grunt/overridetree.cb b/src/mainboard/google/kahlee/variants/grunt/overridetree.cb
index d1e6c3e8f3..99ab16e536 100644
--- a/src/mainboard/google/kahlee/variants/grunt/overridetree.cb
+++ b/src/mainboard/google/kahlee/variants/grunt/overridetree.cb
@@ -45,6 +45,7 @@ chip soc/amd/stoneyridge
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_76)"
register "enable_delay_ms" = "1"
register "has_power_resource" = "1"
+ register "disable_gpio_export_in_crs" = "1"
device i2c 39 on end
end
end
diff --git a/src/mainboard/google/kahlee/variants/nuwani/overridetree.cb b/src/mainboard/google/kahlee/variants/nuwani/overridetree.cb
index 9ca19a0528..adf94e9b08 100644
--- a/src/mainboard/google/kahlee/variants/nuwani/overridetree.cb
+++ b/src/mainboard/google/kahlee/variants/nuwani/overridetree.cb
@@ -95,6 +95,7 @@ chip soc/amd/stoneyridge
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_76)"
register "enable_delay_ms" = "1"
register "has_power_resource" = "1"
+ register "disable_gpio_export_in_crs" = "1"
device i2c 39 on end
end
end
diff --git a/src/mainboard/google/kahlee/variants/treeya/overridetree.cb b/src/mainboard/google/kahlee/variants/treeya/overridetree.cb
index a6f7a1db2a..7d0c3766dc 100644
--- a/src/mainboard/google/kahlee/variants/treeya/overridetree.cb
+++ b/src/mainboard/google/kahlee/variants/treeya/overridetree.cb
@@ -99,6 +99,7 @@ chip soc/amd/stoneyridge
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_76)"
register "enable_delay_ms" = "1"
register "has_power_resource" = "1"
+ register "disable_gpio_export_in_crs" = "1"
device i2c 39 on end
end
end