summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorFrank Chu <frank_chu@pegatron.corp-partner.google.com>2024-03-08 18:24:15 +0800
committerFelix Held <felix-coreboot@felixheld.de>2024-03-19 13:35:46 +0000
commit19453ec7a63421e7dfe24e8ffec66aba16e7d177 (patch)
tree0a177b989994c963629936453636c0dc3492b85a /src/mainboard
parentb5a7bad724331195a397bb150804dbd2aa39ff2c (diff)
mb/google/nissa/var/glassway: Tune I2C timings for 400 kHz
Update touchpad and touchscreen I2C timing. - Data hold time: 300ns - 900ns BUG=b:328724191 BRANCH=firmware-nissa-15217.B TEST=Check wave form and met the spec. I2C1 (touchscreen) Hold time from 83.58ns to 413.87ns I2C5 (touchpad) Hold time from 95.93ns to 425.27ns Change-Id: I65fb1298f9e96ab0b63aba436f6a319f21b38925 Signed-off-by: Frank Chu <frank_chu@pegatron.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81136 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Martin L Roth <gaumless@gmail.com> Reviewed-by: Eric Lai <ericllai@google.com> Reviewed-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-by: Shawn Ku <shawnku@google.com>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/google/brya/variants/glassway/overridetree.cb4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/google/brya/variants/glassway/overridetree.cb b/src/mainboard/google/brya/variants/glassway/overridetree.cb
index 8c779d75f2..29629d44fc 100644
--- a/src/mainboard/google/brya/variants/glassway/overridetree.cb
+++ b/src/mainboard/google/brya/variants/glassway/overridetree.cb
@@ -129,7 +129,7 @@ chip soc/intel/alderlake
.speed = I2C_SPEED_FAST,
.scl_lcnt = 157,
.scl_hcnt = 79,
- .sda_hold = 7,
+ .sda_hold = 40,
}
},
.i2c[2] = {
@@ -156,7 +156,7 @@ chip soc/intel/alderlake
.speed = I2C_SPEED_FAST,
.scl_lcnt = 158,
.scl_hcnt = 79,
- .sda_hold = 7,
+ .sda_hold = 40,
}
},
}"