diff options
| author | Matt DeVillier <matt.devillier@gmail.com> | 2024-01-26 16:09:42 -0600 |
|---|---|---|
| committer | Felix Singer <service+coreboot-gerrit@felixsinger.de> | 2024-02-13 19:20:11 +0000 |
| commit | 1810a184152800468dc1a5d6119f04c028ce39d9 (patch) | |
| tree | 1b07fcd0f27dc62fa1135cba3ec584829f35ce90 /src/mainboard | |
| parent | 32d679e8a423e1aa5aec4f262a69396eaa9d2476 (diff) | |
mb/google/*: Replace use of gfx/generic addr field with display type
Eliminates the use of a magic number, and the resulting DID entry in the
_DOD method is the same.
TEST=build/boot google/drallion, dump SSDT and verify DID entry is
unchanged.
Change-Id: Ic929cf7ec6849ba398653226bbe46d27b4e3fa81
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80200
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <ericllai@google.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Diffstat (limited to 'src/mainboard')
28 files changed, 32 insertions, 32 deletions
diff --git a/src/mainboard/google/brya/variants/anahera/overridetree.cb b/src/mainboard/google/brya/variants/anahera/overridetree.cb index 352a7d173e..b26e42489d 100644 --- a/src/mainboard/google/brya/variants/anahera/overridetree.cb +++ b/src/mainboard/google/brya/variants/anahera/overridetree.cb @@ -93,7 +93,7 @@ chip soc/intel/alderlake # Use ChromeOS privacy screen _HID register "device[0].hid" = ""GOOG0010"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" register "device[0].privacy.enabled" = "1" register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H21)" # DDIB for HDMI @@ -119,7 +119,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/anahera4es/overridetree.cb b/src/mainboard/google/brya/variants/anahera4es/overridetree.cb index 6973854700..93feca87cd 100644 --- a/src/mainboard/google/brya/variants/anahera4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/anahera4es/overridetree.cb @@ -75,7 +75,7 @@ chip soc/intel/alderlake # Use ChromeOS privacy screen _HID register "device[0].hid" = ""GOOG0010"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" register "device[0].privacy.enabled" = "1" register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H21)" # DDIB for HDMI @@ -101,7 +101,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/anraggar/overridetree.cb b/src/mainboard/google/brya/variants/anraggar/overridetree.cb index 5ea8747cf6..0fd63a72a3 100644 --- a/src/mainboard/google/brya/variants/anraggar/overridetree.cb +++ b/src/mainboard/google/brya/variants/anraggar/overridetree.cb @@ -193,7 +193,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI # If HDMI is not enumerated in the kernel, then no GFX device should be added for DDIB register "device[1].name" = ""DD01"" diff --git a/src/mainboard/google/brya/variants/banshee/overridetree.cb b/src/mainboard/google/brya/variants/banshee/overridetree.cb index 6f66bced97..2602c977d4 100644 --- a/src/mainboard/google/brya/variants/banshee/overridetree.cb +++ b/src/mainboard/google/brya/variants/banshee/overridetree.cb @@ -100,7 +100,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/brya0/overridetree.cb b/src/mainboard/google/brya/variants/brya0/overridetree.cb index 876e8747a6..f15525b9e1 100644 --- a/src/mainboard/google/brya/variants/brya0/overridetree.cb +++ b/src/mainboard/google/brya/variants/brya0/overridetree.cb @@ -124,7 +124,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI # If HDMI is not enumerated in the kernel, then no GFX device should be added for DDIB register "device[1].name" = ""DD01"" diff --git a/src/mainboard/google/brya/variants/crota/overridetree.cb b/src/mainboard/google/brya/variants/crota/overridetree.cb index 69f78c1db9..fa8a83e8fc 100644 --- a/src/mainboard/google/brya/variants/crota/overridetree.cb +++ b/src/mainboard/google/brya/variants/crota/overridetree.cb @@ -113,7 +113,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/dochi/overridetree.cb b/src/mainboard/google/brya/variants/dochi/overridetree.cb index 461a7ad7fb..facdfb2fb3 100644 --- a/src/mainboard/google/brya/variants/dochi/overridetree.cb +++ b/src/mainboard/google/brya/variants/dochi/overridetree.cb @@ -93,7 +93,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/felwinter/overridetree.cb b/src/mainboard/google/brya/variants/felwinter/overridetree.cb index 28e0974f2e..16c44af692 100644 --- a/src/mainboard/google/brya/variants/felwinter/overridetree.cb +++ b/src/mainboard/google/brya/variants/felwinter/overridetree.cb @@ -99,7 +99,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) is unused for any ports but still enumerated in the kernel, so GFX device is added for TCP0 diff --git a/src/mainboard/google/brya/variants/gimble/overridetree.cb b/src/mainboard/google/brya/variants/gimble/overridetree.cb index ed8027d933..af41f84e76 100644 --- a/src/mainboard/google/brya/variants/gimble/overridetree.cb +++ b/src/mainboard/google/brya/variants/gimble/overridetree.cb @@ -80,7 +80,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/gimble4es/overridetree.cb b/src/mainboard/google/brya/variants/gimble4es/overridetree.cb index 881c1a1942..eada864b73 100644 --- a/src/mainboard/google/brya/variants/gimble4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/gimble4es/overridetree.cb @@ -45,7 +45,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/kano/overridetree.cb b/src/mainboard/google/brya/variants/kano/overridetree.cb index aeb8ef2506..e04419133f 100644 --- a/src/mainboard/google/brya/variants/kano/overridetree.cb +++ b/src/mainboard/google/brya/variants/kano/overridetree.cb @@ -102,7 +102,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/marasov/overridetree.cb b/src/mainboard/google/brya/variants/marasov/overridetree.cb index 5a266dd954..35cd598697 100644 --- a/src/mainboard/google/brya/variants/marasov/overridetree.cb +++ b/src/mainboard/google/brya/variants/marasov/overridetree.cb @@ -147,7 +147,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/mithrax/overridetree.cb b/src/mainboard/google/brya/variants/mithrax/overridetree.cb index 55026ae485..49dfea867e 100644 --- a/src/mainboard/google/brya/variants/mithrax/overridetree.cb +++ b/src/mainboard/google/brya/variants/mithrax/overridetree.cb @@ -97,7 +97,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) is unused for any ports but still enumerated in the kernel, so GFX device is added for TCP0 diff --git a/src/mainboard/google/brya/variants/omnigul/overridetree.cb b/src/mainboard/google/brya/variants/omnigul/overridetree.cb index efe56a7ede..041680598f 100644 --- a/src/mainboard/google/brya/variants/omnigul/overridetree.cb +++ b/src/mainboard/google/brya/variants/omnigul/overridetree.cb @@ -136,7 +136,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/osiris/overridetree.cb b/src/mainboard/google/brya/variants/osiris/overridetree.cb index 72981cfe56..9225c02a7a 100644 --- a/src/mainboard/google/brya/variants/osiris/overridetree.cb +++ b/src/mainboard/google/brya/variants/osiris/overridetree.cb @@ -76,7 +76,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/primus/overridetree.cb b/src/mainboard/google/brya/variants/primus/overridetree.cb index 7dde42fce9..c4b56ebb23 100644 --- a/src/mainboard/google/brya/variants/primus/overridetree.cb +++ b/src/mainboard/google/brya/variants/primus/overridetree.cb @@ -88,7 +88,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/redrix/overridetree.cb b/src/mainboard/google/brya/variants/redrix/overridetree.cb index 1fe1682782..18436706d8 100644 --- a/src/mainboard/google/brya/variants/redrix/overridetree.cb +++ b/src/mainboard/google/brya/variants/redrix/overridetree.cb @@ -108,7 +108,7 @@ chip soc/intel/alderlake # Use ChromeOS privacy screen _HID register "device[0].hid" = ""GOOG0010"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" register "device[0].privacy.enabled" = "1" register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H21)" # DDIB for HDMI @@ -134,7 +134,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb index b68dec217e..99c29ee833 100644 --- a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb @@ -89,7 +89,7 @@ chip soc/intel/alderlake # Use ChromeOS privacy screen _HID register "device[0].hid" = ""GOOG0010"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" register "device[0].privacy.enabled" = "1" register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H21)" # DDIB for HDMI @@ -115,7 +115,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/brya/variants/skolas/overridetree.cb b/src/mainboard/google/brya/variants/skolas/overridetree.cb index e3879bc93f..92f809fa95 100644 --- a/src/mainboard/google/brya/variants/skolas/overridetree.cb +++ b/src/mainboard/google/brya/variants/skolas/overridetree.cb @@ -123,7 +123,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI # If HDMI is not enumerated in the kernel, then no GFX device should be added for DDIB register "device[1].name" = ""DD01"" diff --git a/src/mainboard/google/brya/variants/skolas4es/overridetree.cb b/src/mainboard/google/brya/variants/skolas4es/overridetree.cb index 7826ea8ddc..ef13b8e4a5 100644 --- a/src/mainboard/google/brya/variants/skolas4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/skolas4es/overridetree.cb @@ -118,7 +118,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI # If HDMI is not enumerated in the kernel, then no GFX device should be added for DDIB register "device[1].name" = ""DD01"" diff --git a/src/mainboard/google/brya/variants/taeko/overridetree.cb b/src/mainboard/google/brya/variants/taeko/overridetree.cb index d6ffb7f9e1..534b6c5340 100644 --- a/src/mainboard/google/brya/variants/taeko/overridetree.cb +++ b/src/mainboard/google/brya/variants/taeko/overridetree.cb @@ -143,7 +143,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB # TCP0 (DP-1) for port C0 register "device[1].name" = ""DD01"" diff --git a/src/mainboard/google/brya/variants/taeko4es/overridetree.cb b/src/mainboard/google/brya/variants/taeko4es/overridetree.cb index 753e7baaaa..fd204338b6 100644 --- a/src/mainboard/google/brya/variants/taeko4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/taeko4es/overridetree.cb @@ -124,7 +124,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB # TCP0 (DP-1) for port C0 register "device[1].name" = ""DD01"" diff --git a/src/mainboard/google/brya/variants/taniks/overridetree.cb b/src/mainboard/google/brya/variants/taniks/overridetree.cb index a2d9512410..9d89cd58ca 100644 --- a/src/mainboard/google/brya/variants/taniks/overridetree.cb +++ b/src/mainboard/google/brya/variants/taniks/overridetree.cb @@ -120,7 +120,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB # TCP0 (DP-1) for port C0 register "device[1].name" = ""DD01"" diff --git a/src/mainboard/google/brya/variants/vell/overridetree.cb b/src/mainboard/google/brya/variants/vell/overridetree.cb index 459f78299d..01ded8ef06 100644 --- a/src/mainboard/google/brya/variants/vell/overridetree.cb +++ b/src/mainboard/google/brya/variants/vell/overridetree.cb @@ -99,7 +99,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB # TCP0 (DP-1) for port C0 register "device[1].name" = ""DD01"" diff --git a/src/mainboard/google/brya/variants/volmar/overridetree.cb b/src/mainboard/google/brya/variants/volmar/overridetree.cb index ef2da0aedc..069d221608 100644 --- a/src/mainboard/google/brya/variants/volmar/overridetree.cb +++ b/src/mainboard/google/brya/variants/volmar/overridetree.cb @@ -94,7 +94,7 @@ chip soc/intel/alderlake # DDIA for eDP register "device[0].name" = ""LCD0"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" # DDIB for HDMI register "device[1].name" = ""DD01"" # TCP0 (DP-1) for port C0 diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index eecdc00a0c..d6200d9a48 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -225,7 +225,7 @@ chip soc/intel/cannonlake register "device[0].name" = ""LCD0"" # Address is set following the ACPI spec section A.3.2 # for an internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" register "device[0].privacy.enabled" = "1" register "device[0].privacy.detect_function" = ""\\_SB.PCI0.LPCB.EC0.GPVD"" register "device[0].privacy.status_function" = ""\\_SB.PCI0.LPCB.EC0.GPVX"" diff --git a/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb b/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb index 0d5a383c7f..cce354cf06 100644 --- a/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb +++ b/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb @@ -185,7 +185,7 @@ chip soc/amd/cezanne # Use ChromeOS privacy screen _HID register "device[0].hid" = ""GOOG0010"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" register "device[0].privacy.enabled" = "1" register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_18)" device generic 0.0 on diff --git a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb index a4c29ca3a1..81e78835c8 100644 --- a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb +++ b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb @@ -76,7 +76,7 @@ chip soc/intel/cannonlake # Use ChromeOS privacy screen HID register "device[0].hid" = ""GOOG0010"" # Internal panel on the first port of the graphics chip - register "device[0].addr" = "0x80010400" + register "device[0].type" = "panel" register "device[0].privacy.enabled" = "1" register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E0)" device generic 0 alias eps on end |