summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorKevin Chiu <Kevin.Chiu@quantatw.com>2020-08-28 10:11:26 +0800
committerPatrick Georgi <pgeorgi@google.com>2020-08-31 06:40:13 +0000
commitcf081ab58cfd7b08f68978ebd4f085076504ccb2 (patch)
tree4bc8a7c1710e8b73b33c0d0c64773caa1c3874fd /src/mainboard
parent28668cded436b4d311de2210684f98d97e70707a (diff)
mb/google/zork: update GPIO config for berknip
berknip does not support stylus, config AGPIO4/5 to NC to prevent unexpected wake event for s3. BUG=b:162376046 BRANCH=zork TEST=emerge-zork coreboot Change-Id: I8d9b711ce1d7300181fe496d490dd33b38bc5983 Signed-off-by: Kevin Chiu <kevin.chiu@quantatw.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/44893 Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/google/zork/variants/berknip/gpio.c19
1 files changed, 17 insertions, 2 deletions
diff --git a/src/mainboard/google/zork/variants/berknip/gpio.c b/src/mainboard/google/zork/variants/berknip/gpio.c
index 8abe59f8e8..c8cb10fa71 100644
--- a/src/mainboard/google/zork/variants/berknip/gpio.c
+++ b/src/mainboard/google/zork/variants/berknip/gpio.c
@@ -8,6 +8,10 @@
#include <ec/google/chromeec/ec.h>
static const struct soc_amd_gpio berknip_bid1_gpio_set_stage_ram[] = {
+ /* PEN_DETECT_ODL - no used */
+ PAD_NC(GPIO_4),
+ /* PEN_POWER_EN - no used */
+ PAD_NC(GPIO_5),
/* DMIC_SEL */
PAD_GPO(GPIO_13, LOW), // Select Camera 1 Dmic
/* USB_OC4_L - USB_A1 */
@@ -29,6 +33,10 @@ static const struct soc_amd_gpio berknip_bid1_gpio_set_stage_ram[] = {
};
static const struct soc_amd_gpio berknip_bid2_gpio_set_stage_ram[] = {
+ /* PEN_DETECT_ODL - no used */
+ PAD_NC(GPIO_4),
+ /* PEN_POWER_EN - no used */
+ PAD_NC(GPIO_5),
/* EN_DEV_BEEP_L */
PAD_GPO(GPIO_89, HIGH),
/* TP */
@@ -37,6 +45,13 @@ static const struct soc_amd_gpio berknip_bid2_gpio_set_stage_ram[] = {
PAD_GPO(GPIO_140, HIGH),
};
+static const struct soc_amd_gpio berknip_gpio_set_stage_ram[] = {
+ /* PEN_DETECT_ODL - no used */
+ PAD_NC(GPIO_4),
+ /* PEN_POWER_EN - no used */
+ PAD_NC(GPIO_5),
+};
+
const struct soc_amd_gpio *variant_override_gpio_table(size_t *size)
{
uint32_t board_version;
@@ -57,6 +72,6 @@ const struct soc_amd_gpio *variant_override_gpio_table(size_t *size)
return berknip_bid2_gpio_set_stage_ram;
}
- *size = 0;
- return NULL;
+ *size = ARRAY_SIZE(berknip_gpio_set_stage_ram);
+ return berknip_gpio_set_stage_ram;
}