diff options
author | Angel Pons <th3fanbus@gmail.com> | 2020-06-22 17:41:49 +0200 |
---|---|---|
committer | Patrick Georgi <pgeorgi@google.com> | 2020-07-01 18:14:31 +0000 |
commit | b6397070561fdbe13ae4a5e5f6b9766426800d55 (patch) | |
tree | 0942f652cd7fe3fae9494598d093ba2c71058e3b /src/mainboard | |
parent | 8edfddcb54cf28a9c5deb4d97d131a47e77cda07 (diff) |
nb/intel/ironlake: Drop copy-pasted and dead code
This function was copy-pasted, comments included, from Sandy Bridge.
However, it is only called with 0x0044 as the northbridge's PCI ID.
Therefore, `bridge_silicon_revision() & BASE_REV_MASK` will always
evaluate to 0x40, which never equals `BASE_REV_SNB`, that is, 0x00.
As the condition is always false, treat this code as dead and drop it.
Following a similar reasoning, all direct comparisons against SNB
steppings will always be true, because `bridge_silicon_revision()`
returns at least 0x40 which is always larger than either `SNB_STEP_D0`
or `SNB_STEP_D1`. So, drop all but the code path that is actually used.
Change-Id: I5219a6af3df98ed77c9c4abfb9a63c2ebf8171bb
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42697
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'src/mainboard')
0 files changed, 0 insertions, 0 deletions