diff options
author | Stefan Reinauer <stepan@coresystems.de> | 2010-04-14 18:59:42 +0000 |
---|---|---|
committer | Stefan Reinauer <stepan@openbios.org> | 2010-04-14 18:59:42 +0000 |
commit | 523ebd927d80807fa8a8c30cddfe0f549b7f62d8 (patch) | |
tree | d26cc7520f89d16260fa1cd989512834bb7dc962 /src/mainboard/technexion | |
parent | 97b21be8c74a2e9da5a7c01944a727e0bab05170 (diff) |
zero warning days. Move RAMTOP and RAMBASE together.
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5435 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/mainboard/technexion')
-rw-r--r-- | src/mainboard/technexion/tim5690/Kconfig | 4 | ||||
-rw-r--r-- | src/mainboard/technexion/tim5690/mainboard.c | 25 | ||||
-rw-r--r-- | src/mainboard/technexion/tim8690/mainboard.c | 7 |
3 files changed, 10 insertions, 26 deletions
diff --git a/src/mainboard/technexion/tim5690/Kconfig b/src/mainboard/technexion/tim5690/Kconfig index ad89af6e84..5541975eb2 100644 --- a/src/mainboard/technexion/tim5690/Kconfig +++ b/src/mainboard/technexion/tim5690/Kconfig @@ -110,7 +110,3 @@ config HEAP_SIZE default 0x4000 depends on BOARD_TECHNEXION_TIM5690 -config RAMBASE - hex - default 0x100000 - depends on BOARD_TECHNEXION_TIM5690 diff --git a/src/mainboard/technexion/tim5690/mainboard.c b/src/mainboard/technexion/tim5690/mainboard.c index 25e9e07e29..8b93cd9c8c 100644 --- a/src/mainboard/technexion/tim5690/mainboard.c +++ b/src/mainboard/technexion/tim5690/mainboard.c @@ -22,11 +22,12 @@ #include <device/pci.h> #include <arch/io.h> #include <boot/coreboot_tables.h> +#include <arch/coreboot_tables.h> #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <device/pci_def.h> -#include <../southbridge/amd/sb600/sb600.h> -#include <../superio/ite/it8712f/it8712f.h> +#include <southbridge/amd/sb600/sb600.h> +#include <superio/ite/it8712f/it8712f.h> #include "chip.h" #include "tn_post_code.h" #include "vgabios.h" @@ -57,7 +58,6 @@ #define TV_MODE_09 0x09 /* SCART-RGB */ #define TV_MODE_NO 0xff /* No TV Support */ - /* The base address is 0x2e or 0x4e, depending on config bytes. */ #define SIO_BASE 0x2e #define SIO_INDEX SIO_BASE @@ -75,12 +75,8 @@ #define IT8712F_CONFIGURATION_PORT 0x2e /* Write-only. */ #define IT8712F_SIMPLE_IO_BASE 0x200 /* Simple I/O base address */ - -extern int do_smbus_read_byte(u32 smbus_io_base, u32 device, u32 address); -extern int do_smbus_write_byte(u32 smbus_io_base, u32 device, u32 address, - u8 val); -extern void lb_add_memory_range(struct lb_memory *mem, uint32_t type, - uint64_t start, uint64_t size); +int do_smbus_read_byte(u32 smbus_io_base, u32 device, u32 address); +int do_smbus_write_byte(u32 smbus_io_base, u32 device, u32 address, u8 val); #define ADT7461_read_byte(address) \ do_smbus_read_byte(SMBUS_IO_BASE, ADT7461_ADDRESS, address) #define ARA_read_byte(address) \ @@ -88,15 +84,8 @@ extern void lb_add_memory_range(struct lb_memory *mem, uint32_t type, #define ADT7461_write_byte(address, val) \ do_smbus_write_byte(SMBUS_IO_BASE, ADT7461_ADDRESS, address, val) -/* previous - */ -void tim5690_enable(device_t dev); -int add_mainboard_resources(struct lb_memory *mem); - - uint64_t uma_memory_base, uma_memory_size; - /* The content of IT8712F_CONFIG_REG_LDN (index 0x07) must be set to the LDN the register belongs to, before you can access the register. */ static void it8712f_sio_write(uint8_t ldn, uint8_t index, uint8_t value) @@ -126,7 +115,6 @@ static void it8712f_exit_conf(void) it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CC, 0x02); } - /* set thermal config */ static void set_thermal_config(void) @@ -236,7 +224,7 @@ void lcd_panel_id(rs690_vbios_regs *vbios_regs, u8 num_id) * enable the dedicated function in tim5690 board. * This function called early than rs690_enable. *************************************************/ -void tim5690_enable(device_t dev) +static void tim5690_enable(device_t dev) { struct mainboard_config *mainboard = (struct mainboard_config *)dev->chip_info; @@ -312,6 +300,7 @@ int add_mainboard_resources(struct lb_memory *mem) uma_memory_base, uma_memory_size); #endif technexion_post_code(LED_MESSAGE_FINISH); + return 0; } struct chip_operations mainboard_ops = { diff --git a/src/mainboard/technexion/tim8690/mainboard.c b/src/mainboard/technexion/tim8690/mainboard.c index 11deef2ad4..b032483fad 100644 --- a/src/mainboard/technexion/tim8690/mainboard.c +++ b/src/mainboard/technexion/tim8690/mainboard.c @@ -22,6 +22,7 @@ #include <device/pci.h> #include <arch/io.h> #include <boot/coreboot_tables.h> +#include <arch/coreboot_tables.h> #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <device/pci_def.h> @@ -145,11 +146,8 @@ static void set_thermal_config(void) * enable the dedicated function in tim8690 board. * This function called early than rs690_enable. *************************************************/ -void tim8690_enable(device_t dev) +static void tim8690_enable(device_t dev) { - struct mainboard_config *mainboard = - (struct mainboard_config *)dev->chip_info; - printk(BIOS_INFO, "Mainboard tim8690 Enable. dev=0x%p\n", dev); #if (CONFIG_GFXUMA == 1) @@ -208,6 +206,7 @@ int add_mainboard_resources(struct lb_memory *mem) lb_add_memory_range(mem, LB_MEM_RESERVED, uma_memory_base, uma_memory_size); #endif + return 0; } struct chip_operations mainboard_ops = { |