diff options
| author | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-04-17 22:24:40 +1000 |
|---|---|---|
| committer | Patrick Georgi <patrick@georgi-clan.de> | 2014-04-26 12:48:46 +0200 |
| commit | 392de45ae2d9550c3b95078bff7a52c9e5eed563 (patch) | |
| tree | 45995f3e407fd8b4857f3a7914aba6f8b918f81a /src/mainboard/technexion | |
| parent | d6060b7142310a7a5d3a4912bbd08d230cad90b1 (diff) | |
mainboard/*: Remove DUMP_ACPI_TABLES from amd boards
Dumping the ACPI tables in this way has limited use, is not likely to be
used and is poorly implemented. There are much more sophisticated tools
available on Linux for debugging ACPI as such this code is outside the
scope of coreboots 'bring up the hardware only' philosophy.
A more generic implemention could be done with hexdump() in coreboot
proper following on from this cleanup.
Change-Id: Ifd3bfb76338609d18fcf7158d3c9a6d7c06c8847
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/5530
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Diffstat (limited to 'src/mainboard/technexion')
| -rw-r--r-- | src/mainboard/technexion/tim5690/acpi_tables.c | 35 | ||||
| -rw-r--r-- | src/mainboard/technexion/tim8690/acpi_tables.c | 35 |
2 files changed, 0 insertions, 70 deletions
diff --git a/src/mainboard/technexion/tim5690/acpi_tables.c b/src/mainboard/technexion/tim5690/acpi_tables.c index 0465c1b7b2..8212ddb321 100644 --- a/src/mainboard/technexion/tim5690/acpi_tables.c +++ b/src/mainboard/technexion/tim5690/acpi_tables.c @@ -32,8 +32,6 @@ extern u16 pm_base; -#define DUMP_ACPI_TABLES 0 - /* * Assume the max pstate number is 8 * 0x21(33 bytes) is one package length of _PSS package @@ -42,22 +40,6 @@ extern u16 pm_base; #define Maxpstate 8 #define Defpkglength 0x21 -#if DUMP_ACPI_TABLES == 1 -static void dump_mem(u32 start, u32 end) -{ - - u32 i; - print_debug("dump_mem:"); - for (i = start; i < end; i++) { - if ((i & 0xf) == 0) { - printk(BIOS_DEBUG, "\n%08x:", i); - } - printk(BIOS_DEBUG, " %02x", (u8)*((u8 *)i)); - } - print_debug("\n"); -} -#endif - extern const unsigned char AmlCode[]; unsigned long acpi_fill_mcfg(unsigned long current) @@ -174,23 +156,6 @@ unsigned long write_acpi_tables(unsigned long start) acpi_create_fadt(fadt, facs, dsdt); acpi_add_table(rsdp, fadt); -#if DUMP_ACPI_TABLES == 1 - printk(BIOS_DEBUG, "rsdp\n"); - dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t)); - - printk(BIOS_DEBUG, "rsdt\n"); - dump_mem(rsdt, ((void *)rsdt) + sizeof(acpi_rsdt_t)); - - printk(BIOS_DEBUG, "madt\n"); - dump_mem(madt, ((void *)madt) + madt->header.length); - - printk(BIOS_DEBUG, "ssdt\n"); - dump_mem(ssdt, ((void *)ssdt) + ssdt->length); - - printk(BIOS_DEBUG, "fadt\n"); - dump_mem(fadt, ((void *)fadt) + fadt->header.length); -#endif - printk(BIOS_INFO, "ACPI: done.\n"); return current; } diff --git a/src/mainboard/technexion/tim8690/acpi_tables.c b/src/mainboard/technexion/tim8690/acpi_tables.c index 0465c1b7b2..8212ddb321 100644 --- a/src/mainboard/technexion/tim8690/acpi_tables.c +++ b/src/mainboard/technexion/tim8690/acpi_tables.c @@ -32,8 +32,6 @@ extern u16 pm_base; -#define DUMP_ACPI_TABLES 0 - /* * Assume the max pstate number is 8 * 0x21(33 bytes) is one package length of _PSS package @@ -42,22 +40,6 @@ extern u16 pm_base; #define Maxpstate 8 #define Defpkglength 0x21 -#if DUMP_ACPI_TABLES == 1 -static void dump_mem(u32 start, u32 end) -{ - - u32 i; - print_debug("dump_mem:"); - for (i = start; i < end; i++) { - if ((i & 0xf) == 0) { - printk(BIOS_DEBUG, "\n%08x:", i); - } - printk(BIOS_DEBUG, " %02x", (u8)*((u8 *)i)); - } - print_debug("\n"); -} -#endif - extern const unsigned char AmlCode[]; unsigned long acpi_fill_mcfg(unsigned long current) @@ -174,23 +156,6 @@ unsigned long write_acpi_tables(unsigned long start) acpi_create_fadt(fadt, facs, dsdt); acpi_add_table(rsdp, fadt); -#if DUMP_ACPI_TABLES == 1 - printk(BIOS_DEBUG, "rsdp\n"); - dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t)); - - printk(BIOS_DEBUG, "rsdt\n"); - dump_mem(rsdt, ((void *)rsdt) + sizeof(acpi_rsdt_t)); - - printk(BIOS_DEBUG, "madt\n"); - dump_mem(madt, ((void *)madt) + madt->header.length); - - printk(BIOS_DEBUG, "ssdt\n"); - dump_mem(ssdt, ((void *)ssdt) + ssdt->length); - - printk(BIOS_DEBUG, "fadt\n"); - dump_mem(fadt, ((void *)fadt) + fadt->header.length); -#endif - printk(BIOS_INFO, "ACPI: done.\n"); return current; } |