summaryrefslogtreecommitdiff
path: root/src/mainboard/system76
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2022-05-04 17:08:11 +0200
committerFelix Held <felix-coreboot@felixheld.de>2022-05-05 17:38:14 +0000
commitda4e1d780656d6a733f7c2445697466c86a8e901 (patch)
tree306e6df6215c3445eb58bd0a677df6da2c52cba6 /src/mainboard/system76
parent7fd65e9b3abd0c0f0359d0d91baf27a441ceaab6 (diff)
soc/intel/tigerlake: Add enum for `DdiPortXConfig`
Add an enum for `DdiPortXConfig` devicetree options. Note that setting these options to zero does not disable the corresponding DDI port, but instead indicates that no LFP (Local Flat Panel, i.e. internal LCD) is connected to it. Change-Id: I9ea10141e51bf29ea44199dcd1b55b63ec771c0a Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/64047 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-by: Tim Crawford <tcrawford@system76.com>
Diffstat (limited to 'src/mainboard/system76')
-rw-r--r--src/mainboard/system76/darp7/devicetree.cb4
-rw-r--r--src/mainboard/system76/galp5/devicetree.cb4
-rw-r--r--src/mainboard/system76/gaze16/devicetree.cb4
-rw-r--r--src/mainboard/system76/lemp10/devicetree.cb4
-rw-r--r--src/mainboard/system76/oryp8/devicetree.cb2
5 files changed, 9 insertions, 9 deletions
diff --git a/src/mainboard/system76/darp7/devicetree.cb b/src/mainboard/system76/darp7/devicetree.cb
index 4b7ad233ea..dd356169ea 100644
--- a/src/mainboard/system76/darp7/devicetree.cb
+++ b/src/mainboard/system76/darp7/devicetree.cb
@@ -94,12 +94,12 @@ chip soc/intel/tigerlake
device ref system_agent on end
device ref igpu on
# DDIA is eDP
- register "DdiPortAConfig" = "1"
+ register "DdiPortAConfig" = "DDI_PORT_CFG_EDP"
register "DdiPortAHpd" = "1"
register "DdiPortADdc" = "0"
# DDIB is HDMI
- register "DdiPortBConfig" = "0"
+ register "DdiPortBConfig" = "DDI_PORT_CFG_NO_LFP"
register "DdiPortBHpd" = "1"
register "DdiPortBDdc" = "1"
diff --git a/src/mainboard/system76/galp5/devicetree.cb b/src/mainboard/system76/galp5/devicetree.cb
index 81163b6547..5650f2061f 100644
--- a/src/mainboard/system76/galp5/devicetree.cb
+++ b/src/mainboard/system76/galp5/devicetree.cb
@@ -94,12 +94,12 @@ chip soc/intel/tigerlake
device ref system_agent on end
device ref igpu on
# DDIA is eDP
- register "DdiPortAConfig" = "1"
+ register "DdiPortAConfig" = "DDI_PORT_CFG_EDP"
register "DdiPortAHpd" = "1"
register "DdiPortADdc" = "0"
# DDIB is HDMI
- register "DdiPortBConfig" = "0"
+ register "DdiPortBConfig" = "DDI_PORT_CFG_NO_LFP"
register "DdiPortBHpd" = "1"
register "DdiPortBDdc" = "1"
diff --git a/src/mainboard/system76/gaze16/devicetree.cb b/src/mainboard/system76/gaze16/devicetree.cb
index a92f044975..fbab7fbaab 100644
--- a/src/mainboard/system76/gaze16/devicetree.cb
+++ b/src/mainboard/system76/gaze16/devicetree.cb
@@ -87,12 +87,12 @@ chip soc/intel/tigerlake
device ref system_agent on end
device ref igpu on
# DDIA is eDP
- register "DdiPortAConfig" = "1"
+ register "DdiPortAConfig" = "DDI_PORT_CFG_EDP"
register "DdiPortAHpd" = "1"
register "DdiPortADdc" = "0"
# DDIB is HDMI
- register "DdiPortBConfig" = "0"
+ register "DdiPortBConfig" = "DDI_PORT_CFG_NO_LFP"
register "DdiPortBHpd" = "1"
register "DdiPortBDdc" = "1"
end
diff --git a/src/mainboard/system76/lemp10/devicetree.cb b/src/mainboard/system76/lemp10/devicetree.cb
index e84c405496..74bd7da99a 100644
--- a/src/mainboard/system76/lemp10/devicetree.cb
+++ b/src/mainboard/system76/lemp10/devicetree.cb
@@ -94,12 +94,12 @@ chip soc/intel/tigerlake
device ref system_agent on end
device ref igpu on
# DDIA is eDP
- register "DdiPortAConfig" = "1"
+ register "DdiPortAConfig" = "DDI_PORT_CFG_EDP"
register "DdiPortAHpd" = "1"
register "DdiPortADdc" = "0"
# DDIB is HDMI
- register "DdiPortBConfig" = "0"
+ register "DdiPortBConfig" = "DDI_PORT_CFG_NO_LFP"
register "DdiPortBHpd" = "1"
register "DdiPortBDdc" = "1"
diff --git a/src/mainboard/system76/oryp8/devicetree.cb b/src/mainboard/system76/oryp8/devicetree.cb
index 65b6e874cd..ec01d8a40c 100644
--- a/src/mainboard/system76/oryp8/devicetree.cb
+++ b/src/mainboard/system76/oryp8/devicetree.cb
@@ -105,7 +105,7 @@ chip soc/intel/tigerlake
end
device ref igpu on
# DDIA is eDP
- register "DdiPortAConfig" = "1"
+ register "DdiPortAConfig" = "DDI_PORT_CFG_EDP"
register "DdiPortAHpd" = "1"
register "DdiPortADdc" = "0"
end