summaryrefslogtreecommitdiff
path: root/src/mainboard/system76
diff options
context:
space:
mode:
authorTim Crawford <tcrawford@system76.com>2024-02-29 11:34:05 -0700
committerFelix Held <felix-coreboot@felixheld.de>2024-03-04 14:54:09 +0000
commitb1ed9f4f87638b9cbde4c2b7b821ebc29f584eec (patch)
tree793673aa189ebd4687d629f2abbaea71ebc04a97 /src/mainboard/system76
parenta78388508c91a82a037efe39f69b3f7d0d8713c5 (diff)
mb/system76/adl,rpl: Add 50ms timeout for PCIe 3.0 RPs
The FSP may fail to detect PCIe 4.0 devices in PCIe 3.0 slots on S3 resume. This issue has only been experienced on lemp12, and only with Samsung drives, but implies it could happen on other systems or with other drives as well. A timeout of 50ms is arbitrarily chosen. Tested on lemp12 with Samsung 980 PRO (FW: 3B2QGXA7, 5B2QGXA7) and 990 PRO (FW: 4B2QJXD7) drives. Change-Id: I4f44fc429c52e407b7566d6bb6dd31b2cf85c48d Signed-off-by: Tim Crawford <tcrawford@system76.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80756 Reviewed-by: Jeremy Soller <jeremy@system76.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/system76')
-rw-r--r--src/mainboard/system76/adl/variants/darp8/overridetree.cb1
-rw-r--r--src/mainboard/system76/adl/variants/gaze17-3050/overridetree.cb1
-rw-r--r--src/mainboard/system76/adl/variants/gaze17-3060-b/overridetree.cb1
-rw-r--r--src/mainboard/system76/adl/variants/lemp11/overridetree.cb1
-rw-r--r--src/mainboard/system76/rpl/variants/gaze18/overridetree.cb1
-rw-r--r--src/mainboard/system76/rpl/variants/lemp12/overridetree.cb1
6 files changed, 6 insertions, 0 deletions
diff --git a/src/mainboard/system76/adl/variants/darp8/overridetree.cb b/src/mainboard/system76/adl/variants/darp8/overridetree.cb
index 05d6a4504c..73d016f17d 100644
--- a/src/mainboard/system76/adl/variants/darp8/overridetree.cb
+++ b/src/mainboard/system76/adl/variants/darp8/overridetree.cb
@@ -152,6 +152,7 @@ chip soc/intel/alderlake
.clk_src = 4,
.clk_req = 4,
.flags = PCIE_RP_LTR,
+ .pcie_rp_detect_timeout_ms = 50,
}"
# FIXME: Drives do not exit D3cold on S3 exit
#chip soc/intel/common/block/pcie/rtd3
diff --git a/src/mainboard/system76/adl/variants/gaze17-3050/overridetree.cb b/src/mainboard/system76/adl/variants/gaze17-3050/overridetree.cb
index 880bb27514..960ead6e5c 100644
--- a/src/mainboard/system76/adl/variants/gaze17-3050/overridetree.cb
+++ b/src/mainboard/system76/adl/variants/gaze17-3050/overridetree.cb
@@ -98,6 +98,7 @@ chip soc/intel/alderlake
.clk_src = 1,
.clk_req = 1,
.flags = PCIE_RP_LTR,
+ .pcie_rp_detect_timeout_ms = 50,
}"
end
device ref pcie_rp9 on
diff --git a/src/mainboard/system76/adl/variants/gaze17-3060-b/overridetree.cb b/src/mainboard/system76/adl/variants/gaze17-3060-b/overridetree.cb
index 90bd5c18a0..74b87ee60e 100644
--- a/src/mainboard/system76/adl/variants/gaze17-3060-b/overridetree.cb
+++ b/src/mainboard/system76/adl/variants/gaze17-3060-b/overridetree.cb
@@ -130,6 +130,7 @@ chip soc/intel/alderlake
.clk_src = 1,
.clk_req = 1,
.flags = PCIE_RP_LTR,
+ .pcie_rp_detect_timeout_ms = 50,
}"
end
device ref gbe on end
diff --git a/src/mainboard/system76/adl/variants/lemp11/overridetree.cb b/src/mainboard/system76/adl/variants/lemp11/overridetree.cb
index d31e6a4255..1e652483a9 100644
--- a/src/mainboard/system76/adl/variants/lemp11/overridetree.cb
+++ b/src/mainboard/system76/adl/variants/lemp11/overridetree.cb
@@ -138,6 +138,7 @@ chip soc/intel/alderlake
.clk_src = 1,
.clk_req = 1,
.flags = PCIE_RP_LTR,
+ .pcie_rp_detect_timeout_ms = 50,
}"
# FIXME: Drives do not exit D3cold on S3 exit
#chip soc/intel/common/block/pcie/rtd3
diff --git a/src/mainboard/system76/rpl/variants/gaze18/overridetree.cb b/src/mainboard/system76/rpl/variants/gaze18/overridetree.cb
index dc0e8d8ec2..4c115950d0 100644
--- a/src/mainboard/system76/rpl/variants/gaze18/overridetree.cb
+++ b/src/mainboard/system76/rpl/variants/gaze18/overridetree.cb
@@ -63,6 +63,7 @@ chip soc/intel/alderlake
.clk_src = 1,
.clk_req = 1,
.flags = PCIE_RP_LTR | PCIE_RP_AER,
+ .pcie_rp_detect_timeout_ms = 50,
}"
end
device ref pcie_rp9 on
diff --git a/src/mainboard/system76/rpl/variants/lemp12/overridetree.cb b/src/mainboard/system76/rpl/variants/lemp12/overridetree.cb
index 593ac7c014..34950cc3c6 100644
--- a/src/mainboard/system76/rpl/variants/lemp12/overridetree.cb
+++ b/src/mainboard/system76/rpl/variants/lemp12/overridetree.cb
@@ -79,6 +79,7 @@ chip soc/intel/alderlake
.clk_src = 1,
.clk_req = 1,
.flags = PCIE_RP_LTR,
+ .pcie_rp_detect_timeout_ms = 50,
}"
end
end