diff options
| author | Felix Singer <felixsinger@posteo.net> | 2021-12-05 02:40:26 +0100 |
|---|---|---|
| committer | Felix Singer <felixsinger@posteo.net> | 2021-12-09 21:52:13 +0000 |
| commit | 715b787fd3d1a0e714da795ea3d3eaf28ca49577 (patch) | |
| tree | 36bddb19913ef007da7ba6d4aa29758e21ca189f /src/mainboard/system76 | |
| parent | 2bf2e6d1ccd87cdd8d9c189972eae89e47e542c8 (diff) | |
soc/intel/tigerlake: Hook up SMBus device to devicetree
Hook up `SmbusEnable` FSP setting to devicetree state and drop its
redundant devicetree setting `SmbusEnable`.
The following mainboards enable the SMBus device in the devicetree
despite `SmbusEnable` is not being set.
* google/deltaur
* starlabs/laptop
Thus, set it to off to keep the current state unchanged.
Change-Id: I0789af20beb147fc1a6a7d046cdcea15cb44ce4c
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59883
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/mainboard/system76')
| -rw-r--r-- | src/mainboard/system76/darp7/devicetree.cb | 4 | ||||
| -rw-r--r-- | src/mainboard/system76/galp5/devicetree.cb | 4 | ||||
| -rw-r--r-- | src/mainboard/system76/gaze16/devicetree.cb | 4 | ||||
| -rw-r--r-- | src/mainboard/system76/lemp10/devicetree.cb | 4 | ||||
| -rw-r--r-- | src/mainboard/system76/oryp8/devicetree.cb | 1 |
5 files changed, 4 insertions, 13 deletions
diff --git a/src/mainboard/system76/darp7/devicetree.cb b/src/mainboard/system76/darp7/devicetree.cb index 8c16d2addb..7a3e072236 100644 --- a/src/mainboard/system76/darp7/devicetree.cb +++ b/src/mainboard/system76/darp7/devicetree.cb @@ -329,9 +329,7 @@ chip soc/intel/tigerlake device ref hda on register "PchHdaAudioLinkHdaEnable" = "1" end - device ref smbus on - register "SmbusEnable" = "1" - end + device ref smbus on end device ref fast_spi on end end end diff --git a/src/mainboard/system76/galp5/devicetree.cb b/src/mainboard/system76/galp5/devicetree.cb index b0fa5243fb..aabeedbf6b 100644 --- a/src/mainboard/system76/galp5/devicetree.cb +++ b/src/mainboard/system76/galp5/devicetree.cb @@ -333,9 +333,7 @@ chip soc/intel/tigerlake device ref hda on register "PchHdaAudioLinkHdaEnable" = "1" end - device ref smbus on - register "SmbusEnable" = "1" - end + device ref smbus on end device ref fast_spi on end end end diff --git a/src/mainboard/system76/gaze16/devicetree.cb b/src/mainboard/system76/gaze16/devicetree.cb index 380bdc0c0f..f5f216cc4b 100644 --- a/src/mainboard/system76/gaze16/devicetree.cb +++ b/src/mainboard/system76/gaze16/devicetree.cb @@ -145,9 +145,7 @@ chip soc/intel/tigerlake device ref hda on register "PchHdaAudioLinkHdaEnable" = "1" end - device ref smbus on - register "SmbusEnable" = "1" - end + device ref smbus on end device ref fast_spi on end end end diff --git a/src/mainboard/system76/lemp10/devicetree.cb b/src/mainboard/system76/lemp10/devicetree.cb index 5c702b9fe1..2c03e60d81 100644 --- a/src/mainboard/system76/lemp10/devicetree.cb +++ b/src/mainboard/system76/lemp10/devicetree.cb @@ -294,9 +294,7 @@ chip soc/intel/tigerlake device ref hda on register "PchHdaAudioLinkHdaEnable" = "1" end - device ref smbus on - register "SmbusEnable" = "1" - end + device ref smbus on end device ref fast_spi on end end end diff --git a/src/mainboard/system76/oryp8/devicetree.cb b/src/mainboard/system76/oryp8/devicetree.cb index 429ad621c4..4263806b34 100644 --- a/src/mainboard/system76/oryp8/devicetree.cb +++ b/src/mainboard/system76/oryp8/devicetree.cb @@ -212,7 +212,6 @@ chip soc/intel/tigerlake register "PchHdaAudioLinkHdaEnable" = "1" end device ref smbus on - register "SmbusEnable" = "1" chip drivers/i2c/tas5825m register "id" = "0" device i2c 4e on end # (8bit address: 0x9c) |