diff options
| author | Tim Crawford <tcrawford@system76.com> | 2022-08-19 13:18:24 -0600 |
|---|---|---|
| committer | Martin L Roth <gaumless@gmail.com> | 2022-11-24 17:51:54 +0000 |
| commit | 705ebbea04778cef3b51bc7a06b216fd73a193d2 (patch) | |
| tree | fbd06dbbad58a043a0a06497df3e9011a418c34a /src/mainboard/system76/kbl-u | |
| parent | c9cb8ff8fbc107c45a7583241032a401baa217f5 (diff) | |
mb/system76: Reset Realtek codec before configuring
Perform a codec reset before configuring to avoid potential issues like
oryp5 had before 86f410479ca9 ("mb/system76/oryp5: Reset HDA before
configuring").
Inspecting proprietary firmware for multiple boards shows that this is
always done as well.
Change-Id: I64c1fd23f708f77a81fad0bc889f42d4df3f6e61
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66918
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jeremy Soller <jeremy@system76.com>
Diffstat (limited to 'src/mainboard/system76/kbl-u')
| -rw-r--r-- | src/mainboard/system76/kbl-u/variants/galp2/hda_verb.c | 3 | ||||
| -rw-r--r-- | src/mainboard/system76/kbl-u/variants/galp3-b/hda_verb.c | 3 | ||||
| -rw-r--r-- | src/mainboard/system76/kbl-u/variants/galp3/hda_verb.c | 3 |
3 files changed, 6 insertions, 3 deletions
diff --git a/src/mainboard/system76/kbl-u/variants/galp2/hda_verb.c b/src/mainboard/system76/kbl-u/variants/galp2/hda_verb.c index 8e5012b473..208107ce36 100644 --- a/src/mainboard/system76/kbl-u/variants/galp2/hda_verb.c +++ b/src/mainboard/system76/kbl-u/variants/galp2/hda_verb.c @@ -6,8 +6,9 @@ const u32 cim_verb_data[] = { /* Realtek, ALC269VC */ 0x10ec0269, /* Vendor ID */ 0x15581303, /* Subsystem ID */ - 11, /* Number of entries */ + 12, /* Number of entries */ AZALIA_SUBVENDOR(0, 0x15581303), + AZALIA_RESET(1), AZALIA_PIN_CFG(0, 0x12, 0x90a60140), AZALIA_PIN_CFG(0, 0x14, 0x90170120), AZALIA_PIN_CFG(0, 0x15, 0x02211010), diff --git a/src/mainboard/system76/kbl-u/variants/galp3-b/hda_verb.c b/src/mainboard/system76/kbl-u/variants/galp3-b/hda_verb.c index a7c927f82a..2e43bef9b7 100644 --- a/src/mainboard/system76/kbl-u/variants/galp3-b/hda_verb.c +++ b/src/mainboard/system76/kbl-u/variants/galp3-b/hda_verb.c @@ -6,8 +6,9 @@ const u32 cim_verb_data[] = { /* Realtek, ALC269VC */ 0x10ec0269, /* Vendor ID */ 0x15581414, /* Subsystem ID */ - 11, /* Number of entries */ + 12, /* Number of entries */ AZALIA_SUBVENDOR(0, 0x15581414), + AZALIA_RESET(1), AZALIA_PIN_CFG(0, 0x12, 0x90a60140), AZALIA_PIN_CFG(0, 0x14, 0x90170120), AZALIA_PIN_CFG(0, 0x15, 0x02211010), diff --git a/src/mainboard/system76/kbl-u/variants/galp3/hda_verb.c b/src/mainboard/system76/kbl-u/variants/galp3/hda_verb.c index 83cd41de02..de588d5d4e 100644 --- a/src/mainboard/system76/kbl-u/variants/galp3/hda_verb.c +++ b/src/mainboard/system76/kbl-u/variants/galp3/hda_verb.c @@ -6,8 +6,9 @@ const u32 cim_verb_data[] = { /* Realtek, ALC269VC */ 0x10ec0269, /* Vendor ID */ 0x15581313, /* Subsystem ID */ - 11, /* Number of entries */ + 12, /* Number of entries */ AZALIA_SUBVENDOR(0, 0x15581313), + AZALIA_RESET(1), AZALIA_PIN_CFG(0, 0x12, 0x90a60140), AZALIA_PIN_CFG(0, 0x14, 0x90170120), AZALIA_PIN_CFG(0, 0x15, 0x02211010), |