summaryrefslogtreecommitdiff
path: root/src/mainboard/system76/kbl-u/acpi
diff options
context:
space:
mode:
authorFelix Singer <felixsinger@posteo.net>2022-12-25 17:22:41 +0100
committerFelix Singer <felixsinger@posteo.net>2022-12-29 16:30:15 +0000
commitfcdb03d07957375c5f842a2ca3d5d2a0ab2f34d3 (patch)
tree181d5640b61354cfb94b576ac9b5dc4e4a127a9c /src/mainboard/system76/kbl-u/acpi
parent7fb5bf8893fe311a9ce33f9125b2e111952092c7 (diff)
{ec,mb}/system76/acpi: Use Printf() for debug prints
Change-Id: Ia5ae30a1ee976b8059936027b28ac56f37279217 Signed-off-by: Felix Singer <felixsinger@posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/71516 Reviewed-by: Tim Crawford <tcrawford@system76.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/system76/kbl-u/acpi')
-rw-r--r--src/mainboard/system76/kbl-u/acpi/ec.asl54
-rw-r--r--src/mainboard/system76/kbl-u/acpi/gpe.asl2
-rw-r--r--src/mainboard/system76/kbl-u/acpi/lid.asl4
-rw-r--r--src/mainboard/system76/kbl-u/acpi/s76.asl6
4 files changed, 33 insertions, 33 deletions
diff --git a/src/mainboard/system76/kbl-u/acpi/ec.asl b/src/mainboard/system76/kbl-u/acpi/ec.asl
index 6663a2e819..0899eb0063 100644
--- a/src/mainboard/system76/kbl-u/acpi/ec.asl
+++ b/src/mainboard/system76/kbl-u/acpi/ec.asl
@@ -25,7 +25,7 @@ Device (EC0)
Name (ECOK, 0)
Method (_REG, 2, Serialized) // _REG: Region Availability
{
- Debug = Concatenate("EC: _REG", Concatenate(ToHexString(Arg0), Concatenate(" ", ToHexString(Arg1))))
+ Printf ("EC: _REG %o %o", ToHexString(Arg0), ToHexString(Arg1))
If ((Arg0 == 0x03) && (Arg1 == 1)) {
// Enable hardware touchpad lock, airplane mode, and keyboard backlight keys
ECOS = 1
@@ -55,7 +55,7 @@ Device (EC0)
Name (S3OS, 0)
Method (PTS, 1, Serialized) {
- Debug = Concatenate("EC: PTS: ", ToHexString(Arg0))
+ Printf ("EC: PTS: %o", ToHexString(Arg0))
If (ECOK) {
// Save ECOS during sleep
S3OS = ECOS
@@ -66,7 +66,7 @@ Device (EC0)
}
Method (WAK, 1, Serialized) {
- Debug = Concatenate("EC: WAK: ", ToHexString(Arg0))
+ Printf ("EC: WAK: %o", ToHexString(Arg0))
If (ECOK) {
// Restore ECOS after sleep
ECOS = S3OS
@@ -89,42 +89,42 @@ Device (EC0)
Method (_Q0A, 0, NotSerialized) // Touchpad Toggle
{
- Debug = "EC: Touchpad Toggle"
+ Printf ("EC: Touchpad Toggle")
}
Method (_Q0B, 0, NotSerialized) // Screen Toggle
{
- Debug = "EC: Screen Toggle"
+ Printf ("EC: Screen Toggle")
}
Method (_Q0C, 0, NotSerialized) // Mute
{
- Debug = "EC: Mute"
+ Printf ("EC: Mute")
}
Method (_Q0D, 0, NotSerialized) // Keyboard Backlight
{
- Debug = "EC: Keyboard Backlight"
+ Printf ("EC: Keyboard Backlight")
}
Method (_Q0E, 0, NotSerialized) // Volume Down
{
- Debug = "EC: Volume Down"
+ Printf ("EC: Volume Down")
}
Method (_Q0F, 0, NotSerialized) // Volume Up
{
- Debug = "EC: Volume Up"
+ Printf ("EC: Volume Up")
}
Method (_Q10, 0, NotSerialized) // Switch Video Mode
{
- Debug = "EC: Switch Video Mode"
+ Printf ("EC: Switch Video Mode")
}
Method (_Q11, 0, NotSerialized) // Brightness Down
{
- Debug = "EC: Brightness Down"
+ Printf ("EC: Brightness Down")
if (^^^^HIDD.HRDY) {
^^^^HIDD.HPEM (20)
}
@@ -132,7 +132,7 @@ Device (EC0)
Method (_Q12, 0, NotSerialized) // Brightness Up
{
- Debug = "EC: Brightness Up"
+ Printf ("EC: Brightness Up")
if (^^^^HIDD.HRDY) {
^^^^HIDD.HPEM (19)
}
@@ -140,12 +140,12 @@ Device (EC0)
Method (_Q13, 0, NotSerialized) // Camera Toggle
{
- Debug = "EC: Camera Toggle"
+ Printf ("EC: Camera Toggle")
}
Method (_Q14, 0, NotSerialized) // Airplane Mode
{
- Debug = "EC: Airplane Mode"
+ Printf ("EC: Airplane Mode")
if (^^^^HIDD.HRDY) {
^^^^HIDD.HPEM (8)
}
@@ -154,13 +154,13 @@ Device (EC0)
Method (_Q15, 0, NotSerialized) // Suspend Button
{
- Debug = "EC: Suspend Button"
+ Printf ("EC: Suspend Button")
Notify (SLPB, 0x80)
}
Method (_Q16, 0, NotSerialized) // AC Detect
{
- Debug = "EC: AC Detect"
+ Printf ("EC: AC Detect")
^^^^AC.ACFG = ADP
Notify (AC, 0x80) // Status Change
If (BAT0)
@@ -172,25 +172,25 @@ Device (EC0)
Method (_Q17, 0, NotSerialized) // BAT0 Update
{
- Debug = "EC: BAT0 Update (17)"
+ Printf ("EC: BAT0 Update (17)")
Notify (^^^^BAT0, 0x81) // Information Change
}
Method (_Q19, 0, NotSerialized) // BAT0 Update
{
- Debug = "EC: BAT0 Update (19)"
+ Printf ("EC: BAT0 Update (19)")
Notify (^^^^BAT0, 0x81) // Information Change
}
Method (_Q1B, 0, NotSerialized) // Lid Close
{
- Debug = "EC: Lid Close"
+ Printf ("EC: Lid Close")
Notify (LID0, 0x80)
}
Method (_Q1C, 0, NotSerialized) // Thermal Trip
{
- Debug = "EC: Thermal Trip"
+ Printf ("EC: Thermal Trip")
/* TODO
Notify (\_TZ.TZ0, 0x81) // Thermal Trip Point Change
Notify (\_TZ.TZ0, 0x80) // Thermal Status Change
@@ -199,7 +199,7 @@ Device (EC0)
Method (_Q1D, 0, NotSerialized) // Power Button
{
- Debug = "EC: Power Button"
+ Printf ("EC: Power Button")
Notify (PWRB, 0x80)
}
@@ -207,22 +207,22 @@ Device (EC0)
{
Local0 = OEM4
If (Local0 == 0x8A) {
- Debug = "EC: White Keyboard Backlight"
+ Printf ("EC: White Keyboard Backlight")
Notify (^^^^S76D, 0x80)
} ElseIf (Local0 == 0x9F) {
- Debug = "EC: Color Keyboard Toggle"
+ Printf ("EC: Color Keyboard Toggle")
Notify (^^^^S76D, 0x81)
} ElseIf (Local0 == 0x81) {
- Debug = "EC: Color Keyboard Down"
+ Printf ("EC: Color Keyboard Down")
Notify (^^^^S76D, 0x82)
} ElseIf (Local0 == 0x82) {
- Debug = "EC: Color Keyboard Up"
+ Printf ("EC: Color Keyboard Up")
Notify (^^^^S76D, 0x83)
} ElseIf (Local0 == 0x80) {
- Debug = "EC: Color Keyboard Color Change"
+ Printf ("EC: Color Keyboard Color Change")
Notify (^^^^S76D, 0x84)
} Else {
- Debug = Concatenate("EC: Other: ", ToHexString(Local0))
+ Printf ("EC: Other: %o", ToHexString(Local0))
}
}
}
diff --git a/src/mainboard/system76/kbl-u/acpi/gpe.asl b/src/mainboard/system76/kbl-u/acpi/gpe.asl
index b60a132f9c..8b6969473c 100644
--- a/src/mainboard/system76/kbl-u/acpi/gpe.asl
+++ b/src/mainboard/system76/kbl-u/acpi/gpe.asl
@@ -2,7 +2,7 @@
// GPP_C19 SCI
Method (_L13, 0, Serialized) {
- Debug = Concatenate("GPE _L13: ", ToHexString(\_SB.PCI0.LPCB.EC0.WFNO))
+ Printf ("GPE _L13: %o", ToHexString(\_SB.PCI0.LPCB.EC0.WFNO))
If (\_SB.PCI0.LPCB.EC0.ECOK) {
If (\_SB.PCI0.LPCB.EC0.WFNO == 1) {
Notify(\_SB.LID0, 0x80)
diff --git a/src/mainboard/system76/kbl-u/acpi/lid.asl b/src/mainboard/system76/kbl-u/acpi/lid.asl
index 067c96f32b..45ed851850 100644
--- a/src/mainboard/system76/kbl-u/acpi/lid.asl
+++ b/src/mainboard/system76/kbl-u/acpi/lid.asl
@@ -6,7 +6,7 @@ Device (LID0)
Name (_PRW, Package () { 0x13 /* GPP_C19 */, 3 })
Method (_LID, 0, NotSerialized) {
- DEBUG = "LID: _LID"
+ Printf ("LID: _LID")
If (^^PCI0.LPCB.EC0.ECOK) {
Return (^^PCI0.LPCB.EC0.LSTE)
} Else {
@@ -15,7 +15,7 @@ Device (LID0)
}
Method (_PSW, 1, NotSerialized) {
- DEBUG = Concatenate("LID: _PSW: ", ToHexString(Arg0))
+ Printf ("LID: _PSW: %o", ToHexString(Arg0))
If (^^PCI0.LPCB.EC0.ECOK) {
^^PCI0.LPCB.EC0.LWKE = Arg0
}
diff --git a/src/mainboard/system76/kbl-u/acpi/s76.asl b/src/mainboard/system76/kbl-u/acpi/s76.asl
index babca3a82a..53bb801ff4 100644
--- a/src/mainboard/system76/kbl-u/acpi/s76.asl
+++ b/src/mainboard/system76/kbl-u/acpi/s76.asl
@@ -11,13 +11,13 @@ Device (S76D) {
Name (_UID, 0)
Method (RSET, 0, Serialized) {
- Debug = "S76D: RSET"
+ Printf ("S76D: RSET")
SAPL(0)
SKBL(0)
}
Method (INIT, 0, Serialized) {
- Debug = "S76D: INIT"
+ Printf ("S76D: INIT")
RSET()
If (^^PCI0.LPCB.EC0.ECOK) {
// Set flags to use software control
@@ -29,7 +29,7 @@ Device (S76D) {
}
Method (FINI, 0, Serialized) {
- Debug = "S76D: FINI"
+ Printf ("S76D: FINI")
RSET()
If (^^PCI0.LPCB.EC0.ECOK) {
// Set flags to use hardware control