summaryrefslogtreecommitdiff
path: root/src/mainboard/starlabs/starfighter
diff options
context:
space:
mode:
authorSean Rhodes <sean@starlabs.systems>2024-10-03 11:12:54 +0100
committerSean Rhodes <sean@starlabs.systems>2024-10-11 11:27:18 +0000
commit68f33d228ef2a79878042b7d62db63f73fa77561 (patch)
treef9572ffb2a2002b363a6d667cdf9dcce11f4a025 /src/mainboard/starlabs/starfighter
parent29b5f1ddcb164bff639ffb631095ab26013284d7 (diff)
mb/starlabs/*: Enhance USB configuration and comments
Some boards use hubs for devices, so correct the ACPI configuration for these ports. Also, add more information to the comments for the ports. Change-Id: I8472130aba8e777557cf68280fa0058dbeb77df9 Signed-off-by: Sean Rhodes <sean@starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84650 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Maxim Polyakov <max.senia.poliak@gmail.com>
Diffstat (limited to 'src/mainboard/starlabs/starfighter')
-rw-r--r--src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb16
1 files changed, 8 insertions, 8 deletions
diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb
index 32775f6817..96c3295dbf 100644
--- a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb
+++ b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb
@@ -87,22 +87,22 @@ chip soc/intel/alderlake
end
device ref gna on end
device ref xhci on
- # Motherboard USB Type C #0
+ # Motherboard USB TBT Type-C #0
register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)"
register "tcss_ports[0]" = "TCSS_PORT_DEFAULT(OC_SKIP)"
- # Motherboard USB Type-C #1
+ # Motherboard USB TBT Type-C #1
register "usb2_ports[1]" = "USB2_PORT_MID(OC_SKIP)"
register "tcss_ports[1]" = "TCSS_PORT_DEFAULT(OC_SKIP)"
- # Motherboard USB Type-A #0
+ # Motherboard USB 3.0 Type-A
register "usb2_ports[2]" = "USB2_PORT_MID(OC0)"
register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)"
# Removable Webcam
register "usb2_ports[4]" = "USB2_PORT_MID(OC_SKIP)"
- # I/O Board USB Type-A
+ # Daughterboard USB 3.0 Type-A + USB 3.0 Type-A
register "usb2_ports[5]" = "USB2_PORT_MID(OC0)"
register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC_SKIP)"
@@ -136,14 +136,14 @@ chip soc/intel/alderlake
device ref usb3_port1 on end
end
chip drivers/usb/acpi
- register "desc" = ""Right USB Type-A""
- register "type" = "UPC_TYPE_USB3_A"
+ register "desc" = ""USB 3.0 Hub""
+ register "type" = "UPC_TYPE_HUB"
register "group" = "ACPI_PLD_GROUP(0, 3)"
device ref usb2_port6 on end
end
chip drivers/usb/acpi
- register "desc" = ""Right USB Type-A""
- register "type" = "UPC_TYPE_USB3_A"
+ register "desc" = ""USB 3.0 Hub""
+ register "type" = "UPC_TYPE_HUB"
register "group" = "ACPI_PLD_GROUP(0, 3)"
device ref usb3_port2 on end
end