summaryrefslogtreecommitdiff
path: root/src/mainboard/siemens
diff options
context:
space:
mode:
authorWerner Zeh <werner.zeh@siemens.com>2021-10-07 16:22:51 +0200
committerFelix Held <felix-coreboot@felixheld.de>2021-10-12 23:56:45 +0000
commit9cae17d028d4bd3b278fc89ada8e06287917e213 (patch)
tree21a594e059eab318dd906ed639cc19e4b07c8e17 /src/mainboard/siemens
parent59a8355e5f75c7e488efd8f7449a2a3e24dbf3dc (diff)
mb/siemens/mc_ehl: Remove unneeded 'half_populated' variable
Since the DRAM population is fixed to both channels on all mc_ehl boards there is no need to have this 'half_populated' variable at all. Simply use a fixed 'false' in the call of 'memcfg_init()' and delete this variable here. Change-Id: I783c17e6d92322a8b0c094cce803108e718011fa Signed-off-by: Werner Zeh <werner.zeh@siemens.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/58177 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Mario Scheithauer <mario.scheithauer@siemens.com> Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Diffstat (limited to 'src/mainboard/siemens')
-rw-r--r--src/mainboard/siemens/mc_ehl/romstage_fsp_params.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/src/mainboard/siemens/mc_ehl/romstage_fsp_params.c b/src/mainboard/siemens/mc_ehl/romstage_fsp_params.c
index a6ed234170..f93e0affe8 100644
--- a/src/mainboard/siemens/mc_ehl/romstage_fsp_params.c
+++ b/src/mainboard/siemens/mc_ehl/romstage_fsp_params.c
@@ -17,9 +17,6 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
static uint8_t spd_data[0x100];
const char *cbfs_hwi_name = "hwinfo.hex";
- /* TODO: Read the resistor strap to get number of memory segments */
- bool half_populated = false;
-
/* Initialize SPD information for LPDDR4x from HW-Info primarily with a fallback to
spd.bin in the case where the SPD data in HW-Info is not available or invalid. */
memset(spd_data, 0, sizeof(spd_data));
@@ -35,5 +32,5 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
spd_info.spd_spec.spd_index = 0x00;
}
/* Initialize variant specific configurations */
- memcfg_init(&memupd->FspmConfig, board_cfg, &spd_info, half_populated);
+ memcfg_init(&memupd->FspmConfig, board_cfg, &spd_info, false);
}