diff options
| author | Werner Zeh <werner.zeh@siemens.com> | 2019-04-12 09:10:27 +0200 |
|---|---|---|
| committer | Werner Zeh <werner.zeh@siemens.com> | 2019-04-15 11:05:34 +0000 |
| commit | a4e5236e8945d0acab13e9d6c69daf1efa7ea726 (patch) | |
| tree | 621af0f75032089b428f497c311dcb8329ca111a /src/mainboard/siemens | |
| parent | 43bb6554a24e1dd9944a7d3f518e4374f9e0be79 (diff) | |
mb/siemens/mc_apl1: Enable HDA in devicetree for all mainboard variants
With commit
'4074ce0cc7 (intel/apollolake: Add HDA to disable_dev function)'
FSP is now requested to switch off HDA PCI device if it is disabled in
devicetree. Doing so results in a warm restart. Normally this event
will be stored in CMOS RAM (if the descriptor is configured to do so)
and therefore no further resets are requested by FSP on the next boots
as long as CMOS RAM is kept alive.
The Siemens mainboards based on Apollo Lake do not have a CMOS battery
and therefore the CMOS is not backed up. This leads to reset requests
from FSP after PCI enumeration on every boot. To avoid this reset enable
HDA in devicetree for these mainboards. Though we do not have any usage
of HDA it should not be an issue that the HDA device is now enabled. The
benefit is though that no reset is requested anymore by FSP.
Change-Id: I637c7c01d73350700c6066fee74fecbb5b93b221
Signed-off-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32295
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Uwe Poeche <uwe.poeche@siemens.com>
Reviewed-by: Mario Scheithauer <mario.scheithauer@siemens.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/siemens')
5 files changed, 5 insertions, 5 deletions
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/devicetree.cb index f3e8a77143..55e610565f 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/devicetree.cb @@ -68,7 +68,7 @@ chip soc/intel/apollolake device pci 0d.1 off end # - PMC device pci 0d.2 on end # - SPI device pci 0d.3 off end # - Shared SRAM - device pci 0e.0 off end # - Audio + device pci 0e.0 on end # - Audio device pci 11.0 on end # - ISH device pci 12.0 on end # - SATA device pci 13.0 on end # - RP 2 - PCIe A 0 - MACPHY diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb index 42c474ecdb..a627e3e4aa 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb @@ -60,7 +60,7 @@ chip soc/intel/apollolake device pci 0d.1 off end # - PMC device pci 0d.2 on end # - SPI device pci 0d.3 off end # - Shared SRAM - device pci 0e.0 off end # - Audio + device pci 0e.0 on end # - Audio device pci 11.0 on end # - ISH device pci 12.0 on end # - SATA device pci 13.0 on end # - RP 2 - PCIe A 0 diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/devicetree.cb index b6839c1cb3..a03f3836ac 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/devicetree.cb @@ -56,7 +56,7 @@ chip soc/intel/apollolake device pci 0d.1 off end # - PMC device pci 0d.2 on end # - SPI device pci 0d.3 off end # - Shared SRAM - device pci 0e.0 off end # - Audio + device pci 0e.0 on end # - Audio device pci 11.0 on end # - ISH device pci 12.0 on end # - SATA device pci 13.0 on end # - RP 2 - PCIe A 0 diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb index e6feb4813e..53a3394a0e 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb @@ -57,7 +57,7 @@ chip soc/intel/apollolake device pci 0d.1 off end # - PMC device pci 0d.2 on end # - SPI device pci 0d.3 off end # - Shared SRAM - device pci 0e.0 off end # - Audio + device pci 0e.0 on end # - Audio device pci 11.0 on end # - ISH device pci 12.0 on end # - SATA device pci 13.0 on end # - RP 2 - PCIe A 0 diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb index 15be7ffc53..f1ed5d2e15 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb @@ -59,7 +59,7 @@ chip soc/intel/apollolake device pci 0d.1 off end # - PMC device pci 0d.2 on end # - SPI device pci 0d.3 off end # - Shared SRAM - device pci 0e.0 off end # - Audio + device pci 0e.0 on end # - Audio device pci 11.0 on end # - ISH device pci 12.0 on end # - SATA device pci 13.0 on end # - RP 2 - PCIe A 0 |