summaryrefslogtreecommitdiff
path: root/src/mainboard/siemens
diff options
context:
space:
mode:
authorAlexandru Gagniuc <mr.nuke.me@gmail.com>2013-11-23 19:22:53 -0600
committerStefan Reinauer <stefan.reinauer@coreboot.org>2013-12-02 22:11:20 +0100
commit72dccce0c9a7cf59ca51a3174fc11eb8899e1761 (patch)
tree0201395e975f173ebc8badcc952598d559e8a745 /src/mainboard/siemens
parentbcfcfa4473357eb6272bc8bcc5e03f4ba517bcd2 (diff)
global: Fix usage of get_option() to make use of CB_CMOS_ codes
Do not directly check the return value of get_option, but instead compare the returned value against a CB_CMOS_ error code, or against CB_SUCCESS. Change-Id: I2fa7761d13ebb5e9b4606076991a43f18ae370ad Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com> Reviewed-on: http://review.coreboot.org/4266 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/mainboard/siemens')
-rw-r--r--src/mainboard/siemens/sitemp_g1p1/mainboard.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/mainboard/siemens/sitemp_g1p1/mainboard.c b/src/mainboard/siemens/sitemp_g1p1/mainboard.c
index 4fc685567f..89309f2335 100644
--- a/src/mainboard/siemens/sitemp_g1p1/mainboard.c
+++ b/src/mainboard/siemens/sitemp_g1p1/mainboard.c
@@ -448,11 +448,11 @@ static void set_thermal_config(void)
cpu_fan_control = cpu_fan_control_defaults;
case_fan_control = case_fan_control_defaults;
- if( get_option(&byte, "cpu_fan_control") == -4 ) {
+ if (get_option(&byte, "cpu_fan_control") == CB_CMOS_CHECKSUM_INVALID) {
printk(BIOS_WARNING, "%s: CMOS checksum invalid, keeping default values\n",__func__);
} else {
// get all the options needed
- if( get_option(&byte, "cpu_fan_control") == 0 )
+ if( get_option(&byte, "cpu_fan_control") == CB_SUCCESS )
cpu_fan_control.enable = byte ? 1 : 0;
get_option(&cpu_fan_control.polarity, "cpu_fan_polarity");
@@ -461,7 +461,7 @@ static void set_thermal_config(void)
get_option(&cpu_fan_control.pwm_min, "cpu_dutycycle_min");
get_option(&cpu_fan_control.pwm_max, "cpu_dutycycle_max");
- if( get_option(&byte, "chassis_fan_control") == 0)
+ if( get_option(&byte, "chassis_fan_control") == CB_SUCCESS)
case_fan_control.enable = byte ? 1 : 0;
get_option(&case_fan_control.polarity, "chassis_fan_polarity");
get_option(&case_fan_control.t_min, "chassis_t_min");
@@ -816,7 +816,7 @@ static void mainboard_init(device_t dev)
dev_name(dev), dev_path(dev), dev->subsystem_vendor, dev->subsystem_device, __func__);
#if CONFIG_PCI_OPTION_ROM_RUN_REALMODE
- if( get_option(&int15_func.regs.func00_LCD_panel_id, "lcd_panel_id") < 0 )
+ if (get_option(&int15_func.regs.func00_LCD_panel_id, "lcd_panel_id") != CB_SUCCESS)
int15_func.regs.func00_LCD_panel_id = PANEL_TABLE_ID_NO;
int15_func.regs.func05_TV_standard = TV_MODE_NO;
install_INT15_function_extensions(&int15_func);