diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2022-11-13 12:48:44 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-01-25 15:05:01 +0000 |
| commit | 7b49c3711298c06f4293c6b31a16834e3e042423 (patch) | |
| tree | b13155fbda1423feebad2a1ffaef7b2d259b2679 /src/mainboard/sapphire/pureplatinumh61 | |
| parent | 4b8ffaee305db625aaed53eda626f2c2e68e2a8c (diff) | |
mainboard: Drop invalid `hyper_threading` option
Drop the `hyper_threading` CMOS option from most boards, as it's most
likely not working properly and causing problems. The main reasons to
remove the option are:
* The used enum is backwards (0 ---> Enable, 1 ---> Disable)
* Platform/SoC code does not honor the `hyper_threading` option
Also, remove the now-unused enum used by the `hyper_threading` option.
Change-Id: Ia8980a951f4751bc2e1a5d0e88835f578259b256
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69523
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Diffstat (limited to 'src/mainboard/sapphire/pureplatinumh61')
| -rw-r--r-- | src/mainboard/sapphire/pureplatinumh61/cmos.default | 1 | ||||
| -rw-r--r-- | src/mainboard/sapphire/pureplatinumh61/cmos.layout | 5 |
2 files changed, 0 insertions, 6 deletions
diff --git a/src/mainboard/sapphire/pureplatinumh61/cmos.default b/src/mainboard/sapphire/pureplatinumh61/cmos.default index 7cd30cc5f9..38f2bd3d69 100644 --- a/src/mainboard/sapphire/pureplatinumh61/cmos.default +++ b/src/mainboard/sapphire/pureplatinumh61/cmos.default @@ -3,4 +3,3 @@ debug_level=Debug power_on_after_fail=Enable nmi=Enable sata_mode=AHCI -hyper_threading=Enable diff --git a/src/mainboard/sapphire/pureplatinumh61/cmos.layout b/src/mainboard/sapphire/pureplatinumh61/cmos.layout index 979c8e28ad..fabafefa44 100644 --- a/src/mainboard/sapphire/pureplatinumh61/cmos.layout +++ b/src/mainboard/sapphire/pureplatinumh61/cmos.layout @@ -21,9 +21,6 @@ entries 421 1 e 9 sata_mode -# coreboot config options: cpu -424 1 e 2 hyper_threading - # coreboot config options: northbridge 432 3 e 11 gfx_uma_size @@ -42,8 +39,6 @@ enumerations #ID value text 1 0 Disable 1 1 Enable -2 0 Enable -2 1 Disable 4 0 Fallback 4 1 Normal 6 0 Emergency |