diff options
author | Piotr Kleinschmidt <piotr.kleinschmidt@3mdeb.com> | 2020-06-18 12:30:42 +0200 |
---|---|---|
committer | Nico Huber <nico.h@gmx.de> | 2020-07-02 19:32:43 +0000 |
commit | 899b28acdb0f65521405540b7a52b2ad05049720 (patch) | |
tree | 77a63cb12796f6859980f943bae88c61b44e03b1 /src/mainboard/samsung/lumpy | |
parent | 43bcc7b6ed1502de80a857f94443f7c83269ad36 (diff) |
mb/pcengines/apu1/mainboard.c: reorder includes
Originally, there was problem with PC Engines apu1 platform
which returned serial number value as -64. It was caused by wrong
value of dev->bus->secondary.
Source of the problem is in Porting.h header file. It contains
'#pragma pack(1)' which affects struct device. As mainboard.c
uses different binary layout because of this attribute,
reference dev->bus->secondary lands at wrong memory address.
This patch reorder includes and put <AGESA.h> and <AMD.h>
at the end of list, making struct device consistent.
As a result bus number value in device's structure is correct
and hence serial number.
TEST=`dmidecode -t 2` command in Linux Debian
Signed-off-by: Piotr Kleinschmidt <piotr.kleinschmidt@3mdeb.com>
Change-Id: I5e8690d100b38ac7889395d375c0ff32bdefda0b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42512
Reviewed-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/samsung/lumpy')
0 files changed, 0 insertions, 0 deletions